Allow readBuff and readString to succeed even when multiple Read calls are needed
#26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io.ReadFull will Read multiple times if necessary, returning an error if there really isn't enough data left in the reader. We don't need to check how many bytes it actually read, because it anyway returns an error if it fails to properly fill the buffer.
barnardb
changed the title
readBuff and readString to succeed even when multiple Read calls are needed
barnardb
force-pushed
the
fix-readBuf
branch
from
4301ce9 to
2da3063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
readBuffandreadStringmethods inbinaryReaderwere directly callingReadon their buffered reader. TheReadmethod may not fill the entire buffer that it is passed, so calls toreadBuffandreadStringcould fail when the buffered reader's buffer only contained part of the data to be read.io.ReaderFulldoes what we want: it callsReadon the reader multiple times if needed in order to fill our buffer, returning an error only if there really isn't enough data left in the reader.