Initial Machinery interface for Phoenix Apps #14

joaomdmoura · 2017-12-26T14:49:21Z

Related to: #4

This is a major feature for Machinery before 1.0.

The idea is to provide a GUI that represents the states and the resources at each state.
This will provide a helpful and good way for developers to debug or even as an internal (admin like) tool.

Merging this will add a bunch of new dependencies to Machinery, because of that I've been considering spinning it off as its own project, but not sure about it yet.

This is how it looks so far:

joaomdmoura · 2017-12-26T14:50:00Z

lib/web/static/js/app.js

+
+$("#menu-toggle").click(function(e) {
+  e.preventDefault();
+  $("#wrapper").toggleClass("toggled");


Strings must use singlequote.

Read more about it here.

joaomdmoura · 2017-12-26T14:50:00Z

lib/web/static/js/app.js

+
+$("#menu-toggle").click(function(e) {
+  e.preventDefault();
+  $("#wrapper").toggleClass("toggled");


Strings must use singlequote.

Read more about it here.

joaomdmoura · 2017-12-26T14:50:00Z

lib/web/static/js/app.js

+
+$("#menu-toggle").click(function(e) {
+  e.preventDefault();
+  $("#wrapper").toggleClass("toggled");


Possible undefined variable: '$' is not defined.

If this is intended to be a global variable, you can supress this warning by adding a /*global [VARIABLE NAME] */ comment on this file or set it under the globals section of your .eslintrc configuration.

Read more about it here.

joaomdmoura · 2017-12-26T14:50:00Z

lib/web/static/js/app.js

+// If you no longer want to use a dependency, remember
+// to also remove its path from "config.paths.watched".
+
+$("#menu-toggle").click(function(e) {


Strings must use singlequote.

Read more about it here.

joaomdmoura · 2017-12-26T14:50:00Z

lib/web/static/js/app.js

+// If you no longer want to use a dependency, remember
+// to also remove its path from "config.paths.watched".
+
+$("#menu-toggle").click(function(e) {


Possible undefined variable: '$' is not defined.

If this is intended to be a global variable, you can supress this warning by adding a /*global [VARIABLE NAME] */ comment on this file or set it under the globals section of your .eslintrc configuration.

Read more about it here.

joaomdmoura · 2017-12-26T14:50:02Z

lib/web/static/css/app.css

+  }
+}
+
+.topbar h1 {


Heading (h1) should not be qualified.

joaomdmoura · 2017-12-26T14:50:02Z

lib/web/static/css/app.css

+  margin: 0px 10px;
+}
+
+nav.topbar {


Rule doesn't have all its properties in alphabetical ordered.

joaomdmoura · 2017-12-26T14:50:02Z

lib/web/static/css/app.css

+  padding: 15px 15px;
+  background-color: rgb(241, 239, 239);
+  border-radius: .3rem;
+  margin: 0px 10px;


Values of 0 shouldn't have units specified.

joaomdmoura · 2017-12-26T14:50:02Z

lib/web/static/css/app.css

+  color: #666;
+}
+
+div.filled {


Element (div.filled) is overqualified, just use .filled without element name.

joaomdmoura · 2017-12-26T14:50:02Z

lib/web/static/css/app.css

+  color: #666;
+}
+
+div.filled {


Rule doesn't have all its properties in alphabetical ordered.

joaomdmoura · 2017-12-31T00:59:05Z

lib/web/static/js/app.js

+      resourcesLists.insertAdjacentHTML('beforeend', template);
+    })
+  });
+}


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:05Z

lib/web/static/js/app.js

+      </div>
+      `
+      resourcesLists.insertAdjacentHTML('beforeend', template);
+    })


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:05Z

lib/web/static/js/app.js

+        </div>
+      </div>
+      `
+      resourcesLists.insertAdjacentHTML('beforeend', template);


Possible undefined variable: 'template' is not defined.

If this is intended to be a global variable, you can supress this warning by adding a /*global [VARIABLE NAME] */ comment on this file or set it under the globals section of your .eslintrc configuration.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:05Z

lib/web/static/js/app.js

+          </div>
+        </div>
+      </div>
+      `


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:05Z

lib/web/static/js/app.js

+              <table class="table table-striped">
+                <tbody>
+                  ${
+                    "lol"


Strings must use singlequote.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:06Z

lib/web/static/js/app.js

+          list.parentNode.querySelector('.info').innerHTML = error_alert_markup
+        }
+      }
+    }


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:06Z

lib/web/static/js/app.js

+        if (xhr.status === OK) {
+          callback(JSON.parse(xhr.response))
+        } else {
+          list.parentNode.querySelector('.info').innerHTML = error_alert_markup


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:06Z

lib/web/static/js/app.js

+        if (xhr.status === OK) {
+          callback(JSON.parse(xhr.response))
+        } else {
+          list.parentNode.querySelector('.info').innerHTML = error_alert_markup


Identifier 'error_alert_markup' is not in camel case.

Enforce the usage of camel case to have a consistent codebase.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:06Z

lib/web/static/js/app.js

+
+      if (xhr.readyState === DONE) {
+        if (xhr.status === OK) {
+          callback(JSON.parse(xhr.response))


Missing semicolon.

Read more about it here.

joaomdmoura · 2017-12-31T00:59:06Z

lib/web/static/js/app.js

+
+  getResourcesForState(list, callback) {
+    let xhr = new XMLHttpRequest();
+    let state = list.dataset.state


Missing semicolon.

Read more about it here.

coveralls · 2018-01-02T15:33:58Z

Coverage decreased (-1.4%) to 98.649% when pulling 3014b59 on state-gui into c28442f on master.

coveralls · 2018-01-02T16:21:40Z

Coverage decreased (-1.4%) to 98.649% when pulling d32d4ec on state-gui into c28442f on master.

joaomdmoura added 8 commits December 21, 2017 23:59

adding new ply to control web interface access

42c327d

working on web structure to server machinery gui

01c7e7d

Rolling back intial implementation

37ebe44

adding new initial working version of gui backbone

6d943f1

Removing uncessary files and updating the implementation of gui

e46a69d

updating dependencies and mix file

51a025c

Adding intial interface work

be9cc39

Improving the interface and Loading the resoruces properly

b62bdfe

joaomdmoura added the Working in Progress label Dec 26, 2017

joaomdmoura self-assigned this Dec 26, 2017

joaomdmoura commented Dec 26, 2017

View reviewed changes

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from 56a7e3e to b1db36b Compare December 26, 2017 15:41

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from b1db36b to 8ab94f0 Compare December 26, 2017 15:42

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from 8ab94f0 to db28422 Compare December 26, 2017 15:47

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from db28422 to c1d682b Compare December 26, 2017 15:49

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from c1d682b to bbf63ce Compare December 26, 2017 15:58

reorganizing css and fixing css issues

b169047

Repository owner deleted a comment from coveralls Dec 26, 2017

joaomdmoura force-pushed the state-gui branch from bbf63ce to b169047 Compare December 26, 2017 16:30

Fixing Elixir clarity and styles issues

1469b7d

Repository owner deleted a comment from coveralls Dec 26, 2017

Repository owner deleted a comment from coveralls Dec 27, 2017

joaomdmoura force-pushed the state-gui branch from 226a730 to 5d3cb7c Compare December 27, 2017 03:13

joaomdmoura force-pushed the state-gui branch 2 times, most recently from e719eae to 7ab2340 Compare December 28, 2017 18:43

Adding new tests covering Machinery.Plug

e34e4fa

joaomdmoura force-pushed the state-gui branch from 7ab2340 to e34e4fa Compare December 28, 2017 18:44

Repository owner deleted a comment from coveralls Dec 28, 2017

Adding first version of the js integration

0e000eb

joaomdmoura commented Dec 31, 2017

View reviewed changes

Repository owner deleted a comment from coveralls Jan 1, 2018

joaomdmoura force-pushed the state-gui branch from 1c191c9 to 85bd5e0 Compare January 1, 2018 04:37

Refactoring JS implementation of Machinery Dashboard

3cc3771

joaomdmoura force-pushed the state-gui branch 2 times, most recently from a8ca7d9 to 5db5740 Compare January 1, 2018 18:29

Repository owner deleted a comment from coveralls Jan 1, 2018

joaomdmoura force-pushed the state-gui branch from 5db5740 to 2f8d0c6 Compare January 2, 2018 02:23

adding new test to cover api behaviour

3014b59

joaomdmoura force-pushed the state-gui branch from 2f8d0c6 to 3014b59 Compare January 2, 2018 15:32

Repository owner deleted a comment from coveralls Jan 2, 2018

joaomdmoura changed the title ~~[WIP] Initial Machinery interface for Phoenix Apps~~ Initial Machinery interface for Phoenix Apps Jan 2, 2018

joaomdmoura added enhancement and removed Working in Progress labels Jan 2, 2018

joaomdmoura added 2 commits January 2, 2018 14:17

Updating CHANGELOG and README

6605511

enabling assets load from custom dashbaord paths

d32d4ec

joaomdmoura merged commit da9b62d into master Jan 2, 2018

joaomdmoura deleted the state-gui branch January 2, 2018 16:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial Machinery interface for Phoenix Apps #14

Initial Machinery interface for Phoenix Apps #14

joaomdmoura commented Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 26, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

joaomdmoura Dec 31, 2017

coveralls commented Jan 2, 2018

coveralls commented Jan 2, 2018

Initial Machinery interface for Phoenix Apps #14

Initial Machinery interface for Phoenix Apps #14

Conversation

joaomdmoura commented Dec 26, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

coveralls commented Jan 2, 2018

coveralls commented Jan 2, 2018