Adding support for wildcard transitions. #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature will enable people to add transitions that can be made from any state, pretty useful for use cases where a 'canceled' state might exist, you can easily declare it as a valid transition from any state using a wildcard "*" => "next_state"
joaomdmoura
commented
Mar 30, 2018
test/machinery_test.exs
Outdated
| assert {:ok, %TestStruct{state: "canceled"}} = Machinery.transition_to(completed_struct, TestStateMachine, "canceled") | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
There should be no more than 1 consecutive blank lines.
bragamat
reviewed
Mar 30, 2018
| } | ||
| assert Transition.declared_transition?(transitions, "created", "completed") | ||
| assert Transition.declared_transition?(transitions, "created", "canceled") | ||
| assert Transition.declared_transition?(transitions, "completed", "canceled") | ||
| end | ||
| end |
There was a problem hiding this comment.
about this last "end", is it closing a "do" statement before line 5 or something ?
There was a problem hiding this comment.
Yup, closing the module itself , the module MachineryTest.TransitionTes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #17
This feature will enable people to add transitions that can be
made from any state, pretty useful for use cases where a 'canceled'
state might exist, you can easily declare it as a valid transition from
any state using a wildcard "*" => "next_state"