Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use int instead of float to calculate weights_ptr #512

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use int instead of float to calculate weights_ptr #512

wants to merge 1 commit into from

Conversation

qianzhangxa
Copy link

The Config structure consists of 7 fields of int type, so we should use int instead of float when calculating weights_ptr.

@jameswdelancey
Copy link
Contributor

Haha yea. I noticed that too but the size is the same.

@jameswdelancey
Copy link
Contributor

Been in the code a long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qianzhangxa @jameswdelancey