Merge pull request #326 from kasecato/#192/refactor

Fix #192 that isn't work refactor.extract.field
kasecato · Feb 22, 2024 · 089e67a · 089e67a
2 parents e01e654 + 1a722e5
commit 089e67a
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 17 deletions.
diff --git a/README.md b/README.md
@@ -214,13 +214,13 @@ alt+delete | cmd+delete | Safe Delete | N/A
 shift+f6 | shift+f6 | Rename | ✅
 shift+f6 | shift+f6 | Select All Occurrences | ✅
 shift+f6 | shift+f6 | Rename (File) | ✅
-ctrl+f6 | cmd+f6 | Change Signature | N/A
+ctrl+f6 | cmd+f6 | Change Signature | ✅
 ctrl+alt+n | cmd+alt+n | Inline | N/A
 ctrl+alt+m | cmd+alt+m | Extract Method | ✅
 ctrl+alt+v | cmd+alt+v | Extract Variable | ✅
 ctrl+alt+f | cmd+alt+f | Extract Field | ✅
 ctrl+alt+c | cmd+alt+c | Extract Constant | ✅
-ctrl+alt+p | cmd+alt+p | Extract Parameter | N/A
+ctrl+alt+p | cmd+alt+p | Introduce Parameter | ✅
 
 ### VCS/Local History
 
@@ -263,7 +263,7 @@ alt+9 | cmd+9 | Close corresponding tool window (Git) | ✅
 alt+numpad9 | cmd+numpad9 | Close corresponding tool window (Git) | ✅
 ctrl+s | cmd+s | Save all | ✅
 ctrl+alt+y | cmd+alt+y | Synchronize | N/A
-ctrl+alt+f | ctrl+cmd+f | Toggle full screen mode | ✅
+N/A | ctrl+cmd+f | Toggle full screen mode | ✅
 ctrl+shift+f12 | cmd+shift+f12 | Toggle maximizing editor | ✅
 alt+shift+f | alt+shift+f | Add to Favorites | N/A
 alt+shift+i | alt+shift+i | Inspect current file with current profile | N/A

diff --git a/package.json b/package.json
@@ -1158,7 +1158,17 @@
                 "when": "explorerViewletVisible && filesExplorerFocus",
                 "intellij": "Rename (File)"
             },
-
+            {
+                "key": "ctrl+[F6]",
+                "mac": "cmd+[F6]",
+                "command": "editor.action.codeAction",
+                "when": "editorTextFocus",
+                "args": {
+                    "kind": "refactor.change.signature",
+                    "apply": "ifSingle"
+                },
+                "intellij": "Change Signature"
+            },
 
             {
                 "key": "ctrl+alt+m",
@@ -1204,7 +1214,17 @@
                     "apply": "ifSingle"
                 }
             },
-
+            {
+                "key": "ctrl+alt+p",
+                "mac": "cmd+alt+p",
+                "command": "editor.action.codeAction",
+                "when": "editorTextFocus",
+                "args": {
+                    "kind": "refactor.introduce.parameter",
+                    "apply": "ifSingle"
+                },
+                "intellij": "Introduce Parameter"
+            },
 
             {
                 "key": "ctrl+alt+k",
@@ -1370,7 +1390,6 @@
             },
 
             {
-                "key": "ctrl+alt+f", 
                 "mac": "ctrl+cmd+f",
                 "command": "workbench.action.toggleFullScreen",
                 "intellij": "Toggle full screen mode"

diff --git a/src/package-with-comment.json b/src/package-with-comment.json
@@ -1539,16 +1539,17 @@
                 "when": "explorerViewletVisible && filesExplorerFocus",
                 "intellij": "Rename (File)"
             },
-            /*
             {
                 "key": "ctrl+[F6]",
                 "mac": "cmd+[F6]",
-                "command": "",
+                "command": "editor.action.codeAction",
                 "when": "editorTextFocus",
-                "intellij": "Change Signature",
-                "todo": "N/A"
+                "args": {
+                    "kind": "refactor.change.signature",
+                    "apply": "ifSingle"
+                },
+                "intellij": "Change Signature"
             },
-*/
             /*
             {
                 "key": "ctrl+alt+n",
@@ -1603,16 +1604,17 @@
                     "apply": "ifSingle"
                 }
             },
-            /*
             {
                 "key": "ctrl+alt+p",
                 "mac": "cmd+alt+p",
-                "command": "",
+                "command": "editor.action.codeAction",
                 "when": "editorTextFocus",
-                "intellij": "Extract Parameter",
-                "todo": "N/A"
+                "args": {
+                    "kind": "refactor.introduce.parameter",
+                    "apply": "ifSingle"
+                },
+                "intellij": "Introduce Parameter"
             },
-*/
             /*---------------------------------------------------------------*\
              * VCS/Local History
             \*---------------------------------------------------------------*/
@@ -1816,7 +1818,6 @@
             },
 */
             {
-                "key": "ctrl+alt+f", // N/A
                 "mac": "ctrl+cmd+f",
                 "command": "workbench.action.toggleFullScreen",
                 "intellij": "Toggle full screen mode"