Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigate to explorer, changes #119

Closed
quantuminformation opened this issue Jul 25, 2018 · 2 comments
Closed

Navigate to explorer, changes #119

quantuminformation opened this issue Jul 25, 2018 · 2 comments
Assignees
Milestone

Comments

@quantuminformation
Copy link

It would be nice to have for mac:

cmd + 1 -> explorer
cmd + 9 -> vcs changes

just like webstorm

@kasecato kasecato self-assigned this Jul 28, 2018
@kasecato
Copy link
Owner

Hi, @quantuminformation
These key bindings are already available. Please check it 👀

@garbagemule
Copy link

garbagemule commented Aug 15, 2018

It looks like the keybindings are as they should be, but I'm experiencing a case of "sticky panels":

  1. Click on the Explorer icon; the Explorer opens.
  2. Click on the Explorer icon again to close the Explorer.
  3. Hit Cmd+3; Search opens.
  4. Hit Cmd+1; the drawer closes.
  5. Hit Cmd+1 again; the drawer reopens with Search.

In step 4, I expect the drawer to remain open, and I expect Search to be replaced by Explorer. And if that doesn't work, I expect step 5 to bring up Explorer rather than Search. At this point, the only way I can bring up the Explorer seems to be with Cmd+Shift+E or with a mouse click.

In fact, it looks like Search (Cmd+3) is the only panel that will override an already open one. Other hotkeys just appear to be opening or closing the drawer, regardless of what is currently in it. I can't tell if this is a Code issue or an issue with the bindings (or just my setup, but my user settings appear devoid of anything that would interfere), though.

@kasecato can you reproduce this behavior I'm experiencing? Or is everything just working perfectly on your end?

Here's what I'm running:

  • macOS 10.12.6 Sierra
  • Visual Studio Code 1.26.0
  • IntelliJ IDEA Keybindings 0.2.24 (Jun 17, 2018)

Edit: Looks like the specific inconsistencies mentioned above only surface when there are no open editors. With an open editor, I can pull up any of the panels I want, although most of the time it seems like Cmd+1 (Explorer) just closes the drawer instead of directly opening Explorer. Pressing Cmd+1 again correctly opens Explorer.

@kasecato kasecato added the bug label Jan 28, 2024
@kasecato kasecato added this to the v1.5.14 milestone Jan 28, 2024
kasecato added a commit that referenced this issue Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants