Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle comment command wrong shortcut #294

Closed
goshander opened this issue May 17, 2023 · 2 comments
Closed

toggle comment command wrong shortcut #294

goshander opened this issue May 17, 2023 · 2 comments
Assignees
Milestone

Comments

@goshander
Copy link

current command for toggle line comment use wrong shortcut

{
    "key": "ctrl+/",
    "command": "editor.action.commentLine",
    "when": "editorTextFocus && !editorReadonly"
}

need to be more independent of user locale and keyboard layout

{
    "key": "ctrl+[Slash]",
    "command": "editor.action.commentLine",
    "when": "editorTextFocus && !editorReadonly"
}
@goshander goshander changed the title comment command wrong shortcut toggle comment command wrong shortcut May 17, 2023
@kasecato kasecato self-assigned this Aug 11, 2023
@kasecato kasecato added this to the v1.5.10 milestone Aug 11, 2023
kasecato added a commit that referenced this issue Aug 11, 2023
Fixed #294 Keyboard layout-independent bindings
@kasecato
Copy link
Owner

I released it on v1.5.10 now. Please check it

@kasecato kasecato reopened this Aug 11, 2023
@nyurik
Copy link

nyurik commented Aug 15, 2023

I just tried it using Dvorak keyboard layout, and ctrl+z is broken :( I filed #307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants