Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #192 that isn't work refactor.extract.field #326

Merged
merged 3 commits into from
Feb 22, 2024
+37 −17
Merged

Fix #192 that isn't work refactor.extract.field #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6bfa5c5
Fix #192 that isn't work refactor.extract.field
kasecato Feb 22, 2024
831e5a0
Add change signature
kasecato Feb 22, 2024
1a722e5
Add introduce parameter
kasecato Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,13 @@ alt+delete | cmd+delete | Safe Delete | N/A
shift+f6 | shift+f6 | Rename | ✅
shift+f6 | shift+f6 | Select All Occurrences | ✅
shift+f6 | shift+f6 | Rename (File) | ✅
ctrl+f6 | cmd+f6 | Change Signature | N/A
ctrl+f6 | cmd+f6 | Change Signature | ✅
ctrl+alt+n | cmd+alt+n | Inline | N/A
ctrl+alt+m | cmd+alt+m | Extract Method | ✅
ctrl+alt+v | cmd+alt+v | Extract Variable | ✅
ctrl+alt+f | cmd+alt+f | Extract Field | ✅
ctrl+alt+c | cmd+alt+c | Extract Constant | ✅
ctrl+alt+p | cmd+alt+p | Extract Parameter | N/A
ctrl+alt+p | cmd+alt+p | Introduce Parameter | ✅

### VCS/Local History

Expand Down Expand Up @@ -263,7 +263,7 @@ alt+9 | cmd+9 | Close corresponding tool window (Git) | ✅
alt+numpad9 | cmd+numpad9 | Close corresponding tool window (Git) | ✅
ctrl+s | cmd+s | Save all | ✅
ctrl+alt+y | cmd+alt+y | Synchronize | N/A
ctrl+alt+f | ctrl+cmd+f | Toggle full screen mode | ✅
N/A | ctrl+cmd+f | Toggle full screen mode | ✅
ctrl+shift+f12 | cmd+shift+f12 | Toggle maximizing editor | ✅
alt+shift+f | alt+shift+f | Add to Favorites | N/A
alt+shift+i | alt+shift+i | Inspect current file with current profile | N/A
Expand Down
25 changes: 22 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,7 +1158,17 @@
"when": "explorerViewletVisible && filesExplorerFocus",
"intellij": "Rename (File)"
},

{
"key": "ctrl+[F6]",
"mac": "cmd+[F6]",
"command": "editor.action.codeAction",
"when": "editorTextFocus",
"args": {
"kind": "refactor.change.signature",
"apply": "ifSingle"
},
"intellij": "Change Signature"
},

{
"key": "ctrl+alt+m",
Expand Down Expand Up @@ -1204,7 +1214,17 @@
"apply": "ifSingle"
}
},

{
"key": "ctrl+alt+p",
"mac": "cmd+alt+p",
"command": "editor.action.codeAction",
"when": "editorTextFocus",
"args": {
"kind": "refactor.introduce.parameter",
"apply": "ifSingle"
},
"intellij": "Introduce Parameter"
},

{
"key": "ctrl+alt+k",
Expand Down Expand Up @@ -1370,7 +1390,6 @@
},

{
"key": "ctrl+alt+f",
"mac": "ctrl+cmd+f",
"command": "workbench.action.toggleFullScreen",
"intellij": "Toggle full screen mode"
Expand Down
23 changes: 12 additions & 11 deletions src/package-with-comment.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1539,16 +1539,17 @@
"when": "explorerViewletVisible && filesExplorerFocus",
"intellij": "Rename (File)"
},
/*
{
"key": "ctrl+[F6]",
"mac": "cmd+[F6]",
"command": "",
"command": "editor.action.codeAction",
"when": "editorTextFocus",
"intellij": "Change Signature",
"todo": "N/A"
"args": {
"kind": "refactor.change.signature",
"apply": "ifSingle"
},
"intellij": "Change Signature"
},
*/
/*
{
"key": "ctrl+alt+n",
Expand Down Expand Up @@ -1603,16 +1604,17 @@
"apply": "ifSingle"
}
},
/*
{
"key": "ctrl+alt+p",
"mac": "cmd+alt+p",
"command": "",
"command": "editor.action.codeAction",
"when": "editorTextFocus",
"intellij": "Extract Parameter",
"todo": "N/A"
"args": {
"kind": "refactor.introduce.parameter",
"apply": "ifSingle"
},
"intellij": "Introduce Parameter"
},
*/
/*---------------------------------------------------------------*\
* VCS/Local History
\*---------------------------------------------------------------*/
Expand Down Expand Up @@ -1816,7 +1818,6 @@
},
*/
{
"key": "ctrl+alt+f", // N/A
"mac": "ctrl+cmd+f",
"command": "workbench.action.toggleFullScreen",
"intellij": "Toggle full screen mode"
Expand Down