Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 version of the API #8

Open
kevinburke opened this issue Feb 12, 2021 · 0 comments
Open

v2 version of the API #8

kevinburke opened this issue Feb 12, 2021 · 0 comments

Comments

@kevinburke
Copy link
Owner

The current naming scheme overloads the word "jobs" to refer both to individual scheduled jobs and job categories, which is not great. So I'm thinking about a v2 of the API to make this clearer.

POST /v1/jobs => POST /v2/job-types
GET /v2/job-types => new endpoint to retrieve job types
GET /v2/job-types/invoice-shipments => retrieve individual job

# All of these stay the same, just available at v2
PUT /v1/jobs/invoice-shipments/job_123
POST /v1/jobs/invoice-shipments/job_123
POST /v1/jobs/invoice-shipments/job_123/replay
GET /v1/jobs/invoice-shipments/job_123
GET /v1/archived-jobs
kevinburke added a commit that referenced this issue Feb 23, 2021
@kevinburke
server: implement GET /v2/job-types
7e19f8e 
Also start working on passing around a *newmodels.Queries instead of
hardcoding `*newmodels.DB` everywhere.

Add a new `responses` package that can help us get rid of `auto_id`
in the database response, which is something that we don't want to
expose.

Updates #8.
kevinburke added a commit that referenced this issue Feb 23, 2021
@kevinburke
server: implement GET /v2/job-types
ab945f1 
Also start working on passing around a *newmodels.Queries instead of
hardcoding `*newmodels.DB` everywhere.

Add a new `responses` package that can help us get rid of `auto_id`
in the database response, which is something that we don't want to
expose.

Updates #8.
@kevinburke kevinburke mentioned this issue Feb 23, 2021
Merged
kevinburke added a commit that referenced this issue Feb 23, 2021
@kevinburke
server: implement GET /v2/job-types
fad2ade 
Also start working on passing around a *newmodels.Queries instead of
hardcoding `*newmodels.DB` everywhere.

Add a new `responses` package that can help us get rid of `auto_id`
in the database response, which is something that we don't want to
expose.

Updates #8.
kevinburke added a commit that referenced this issue Feb 23, 2021
@kevinburke
server: implement GET /v2/job-types
d246322 
Also start working on passing around a *newmodels.Queries instead of
hardcoding `*newmodels.DB` everywhere.

Add a new `responses` package that can help us get rid of `auto_id`
in the database response, which is something that we don't want to
expose.

Updates #8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinburke