Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing runtime dependencies (@textlint/ast-node-types and traverse) #295

Merged
merged 2 commits into from
Oct 9, 2022

Conversation

kisaragi-hiu
Copy link
Contributor

@kisaragi-hiu kisaragi-hiu commented Oct 8, 2022

This should fix #100.

traverse is required at runtime, by org-to-ast.ts, and yet is declared as a devdependency.

@textlint/ast-node-types is also required at runtime (by org-to-ast.ts and mapping.ts, but is only pulled in indirectly as a devdependency.

As a result,

npm install textlint-plugin-org

doesn't pull either of them in, leading to the error seen in #100.

This PR fixes the missing dependencies.

@kisaragi-hiu kisaragi-hiu marked this pull request as draft October 8, 2022 19:25
@kisaragi-hiu kisaragi-hiu changed the title fix: runtime dependency traverse declared as devdependency fix: missing runtime dependencies (@textlint/ast-node-types and traverse) Oct 8, 2022
@kisaragi-hiu kisaragi-hiu marked this pull request as ready for review October 8, 2022 19:35
@kijimaD
Copy link
Owner

kijimaD commented Oct 9, 2022

@kisaragi-hiu
Thanks!! It seems to good.

@kijimaD kijimaD merged commit 2d720d7 into kijimaD:main Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing depends: traverse
2 participants