Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old fortio redirects are broken #968

Closed
mattmoor opened this issue Jun 19, 2019 · 6 comments · Fixed by #970
Closed

old fortio redirects are broken #968

mattmoor opened this issue Jun 19, 2019 · 6 comments · Fixed by #970
Assignees
Labels
bug Something isn't working

Comments

@mattmoor
Copy link
Member

/assign @srinivashegde86
cc @dushyanthsc

This change removed the go-import <meta> tags that made the old versions work, test-infra needs to move to the fortio.org based import paths ASAP.

istio/istio.io@4d03f08#diff-e3202d59ce8d9d83b8911b4107f87c1e

cc @geeknoid

@mattmoor mattmoor added the bug Something isn't working label Jun 19, 2019
@mattmoor
Copy link
Member Author

This is an indirect dependency for Serving, so once it is fixed in test-infra, I'd like to verify that my auto-update works for serving.

@geeknoid
Copy link

Let me know if you'd like me to reinstate the links for a while.

@mattmoor
Copy link
Member Author

The version of fortio we are on is very old, so I think we need to solve this. If we can't figure it out today, we might reach out about that though. :) thanks @geeknoid

@srinivashegde86
Copy link
Contributor

The sample example mentioned in their docs still uses istio.io - https://github.com/istio/istio/blob/0.3.0/tests/e2e/tests/mixer/mixer_test.go#L37

@srinivashegde86
Copy link
Contributor

Moving to fortio.org fails with "unexpected error while defensively cleaning up after possible derelict nested submodule directories: Entering 'vendor' error: unknown switch `x'"

there was a recent PR in dep when working with submodules - golang/dep#2176. Probably related

@dushyanthsc
Copy link
Contributor

To close the loop here, pinning to a 1.3.1 commit and dep ensure updates the packages correctly. dep ensure -update fortio.org/fortio, tries to pull the latest on fortio and is failing with

 failed to fetch source for fortio.org/fortio: unable to update repository: From https://github.com/fortio/fortio
 ! [rejected]        latest_release -> latest_release  (would clobber existing tag)
: command failed: [git fetch --tags --prune origin]: signal: interrupt

Cynocracy pushed a commit to Cynocracy/test-infra that referenced this issue Jun 13, 2020
…ger lib (knative#968)

* Added release channel support in cluster creation in cluster manager lib
* updated k8s beta dependency to pick up release channel API

* added unit test for the missing coverage in request_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants