translation: Update chapter_sorting / bubble_sort.md #1646
+12
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K3v123
approved these changes
Feb 9, 2025
magentaqin
reviewed
Feb 10, 2025
| 2. Next, perform a "bubble" on the remaining $n - 1$ elements, **swapping the second largest element to its correct position**. | ||
| 3. Similarly, after $n - 1$ rounds of "bubbling," **the top $n - 1$ largest elements will be swapped to their correct positions**. | ||
| 4. The only remaining element is necessarily the smallest and does not require sorting, thus the array sorting is complete. | ||
| 1. First, perform one “bubble” pass on all $n$ elements, **swapping the largest element to its correct position**. |
There was a problem hiding this comment.
1.I think "bubble" is a technical term which could be used directly. How about update to this: perform "bubble" on n elements.
2.This sentence has grammar error. "...elements, and swap the xxx."
There was a problem hiding this comment.
Thank you for the review and suggestions!
- I removed “all” before “𝑛 elements” to make the sentence more concise, as you mentioned.
- I kept the wording:
1. “First, perform one ‘bubble’ pass”
2. “Next, perform a pass”
3. "Continue in this manner; after n-1 such passes,"
to clarify each iteration (not the entire algorithm), and used the structure “[Do X], [swapping Y]” to show the result of each pass, closely reflecting the original Chinese wording '将...'.
Let me know if you approve of these revisions or have any other thoughts—your feedback is greatly appreciated!
line 3 updated. 'reminiscent of' - > 'like'
krahets
reviewed
Feb 15, 2025
K3v123
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this pull request (PR) pertains to Chinese-to-English translation, please confirm that you have read the contribution guidelines and complete the checklist below:
If this pull request (PR) is associated with coding or code transpilation, please attach the relevant console outputs to the PR and complete the following checklist: