Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Commit

Permalink
Renames the svcat --kube-context flag to --context (#1821) (#1997)
Browse files Browse the repository at this point in the history 
* Change svcat --kube-context to --context to align with kubectl (#1821)

* simply renamed the string kube-context flag as context

* did gofmt -w cmd/svcat/plugin/manifest.go to resolve Travis CI test error

* Renamed svcat --kube-context flag to --context  (#1821)
  • Loading branch information
@Bubblemelon @MHBauer
Bubblemelon authored and MHBauer committed Apr 27, 2018
1 parent 7776226 commit 226d847
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 27 deletions.
2 changes: 1 addition & 1 deletion cmd/svcat/main.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func buildRootCommand(cxt *command.Context) *cobra.Command {
},
}

cmd.PersistentFlags().StringVar(&opts.KubeContext, "kube-context", "", "name of the kube context to use")
cmd.PersistentFlags().StringVar(&opts.KubeContext, "context", "", "name of the kubeconfig context to use.")
cmd.PersistentFlags().StringVar(&opts.KubeConfig, "kubeconfig", "", "path to kubeconfig file. Overrides $KUBECONFIG")

cmd.AddCommand(newGetCmd(cxt))
Expand Down
1 change: 0 additions & 1 deletion cmd/svcat/plugin/manifest.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ var reservedFlags = map[string]struct{}{
"help": {},
"insecure-skip-tls-verify": {},
"kubeconfig": {},
"kube-context": {},
"log-backtrace-at": {},
"log-dir": {},
"log-flush-frequency": {},
Expand Down
50 changes: 25 additions & 25 deletions cmd/svcat/testdata/output/completion-bash.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ _svcat_bind()
local_nonpersistent_flags+=("--secret=")
flags+=("--secret-name=")
local_nonpersistent_flags+=("--secret-name=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -273,7 +273,7 @@ _svcat_completion()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -299,7 +299,7 @@ _svcat_deprovision()
flags+=("--namespace=")
two_word_flags+=("-n")
local_nonpersistent_flags+=("--namespace=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -329,7 +329,7 @@ _svcat_describe_binding()
flags+=("--traverse")
flags+=("-t")
local_nonpersistent_flags+=("--traverse")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -351,7 +351,7 @@ _svcat_describe_broker()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -379,7 +379,7 @@ _svcat_describe_class()
flags+=("--uuid")
flags+=("-u")
local_nonpersistent_flags+=("--uuid")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -407,7 +407,7 @@ _svcat_describe_instance()
flags+=("--traverse")
flags+=("-t")
local_nonpersistent_flags+=("--traverse")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -437,7 +437,7 @@ _svcat_describe_plan()
flags+=("--uuid")
flags+=("-u")
local_nonpersistent_flags+=("--uuid")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -464,7 +464,7 @@ _svcat_describe()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -494,7 +494,7 @@ _svcat_get_bindings()
flags+=("--output=")
two_word_flags+=("-o")
local_nonpersistent_flags+=("--output=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -519,7 +519,7 @@ _svcat_get_brokers()
flags+=("--output=")
two_word_flags+=("-o")
local_nonpersistent_flags+=("--output=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -547,7 +547,7 @@ _svcat_get_classes()
flags+=("--uuid")
flags+=("-u")
local_nonpersistent_flags+=("--uuid")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -577,7 +577,7 @@ _svcat_get_instances()
flags+=("--output=")
two_word_flags+=("-o")
local_nonpersistent_flags+=("--output=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -608,7 +608,7 @@ _svcat_get_plans()
flags+=("--uuid")
flags+=("-u")
local_nonpersistent_flags+=("--uuid")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -635,7 +635,7 @@ _svcat_get()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -660,7 +660,7 @@ _svcat_install_plugin()
flags+=("--plugins-path=")
two_word_flags+=("-p")
local_nonpersistent_flags+=("--plugins-path=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -683,7 +683,7 @@ _svcat_install()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -722,7 +722,7 @@ _svcat_provision()
flags+=("--secret=")
two_word_flags+=("-s")
local_nonpersistent_flags+=("--secret=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -746,7 +746,7 @@ _svcat_sync_broker()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -769,7 +769,7 @@ _svcat_sync()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -794,7 +794,7 @@ _svcat_touch_instance()
flags+=("--namespace=")
two_word_flags+=("-n")
local_nonpersistent_flags+=("--namespace=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -817,7 +817,7 @@ _svcat_touch()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -844,7 +844,7 @@ _svcat_unbind()
flags+=("--namespace=")
two_word_flags+=("-n")
local_nonpersistent_flags+=("--namespace=")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand All @@ -869,7 +869,7 @@ _svcat_version()
flags+=("--client")
flags+=("-c")
local_nonpersistent_flags+=("--client")
flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down Expand Up @@ -902,7 +902,7 @@ _svcat()
flags_with_completion=()
flags_completion=()

flags+=("--kube-context=")
flags+=("--context=")
flags+=("--kubeconfig=")
flags+=("--logtostderr")
flags+=("--v=")
Expand Down

0 comments on commit 226d847

Please sign in to comment.