This repository has been archived by the owner on May 6, 2022. It is now read-only.
Rework the logging for controller_instance. #1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
pmorie
reviewed
Oct 12, 2017
pkg/controller/controller.go
Outdated
| @@ -264,8 +267,11 @@ func (c *controller) getClusterServiceClassPlanAndClusterServiceBroker(instance | |||
|
|
|||
| servicePlan, err := c.servicePlanLister.Get(instance.Spec.ClusterServicePlanRef.Name) | |||
| if nil != err { | |||
| s := fmt.Sprintf(`ServiceInstance "%v/%v": references a non-existent ClusterServicePlan %q on ClusterServiceClass %q1`, instance.Namespace, instance.Name, instance.Spec.ExternalClusterServicePlanName, serviceClass.Spec.ExternalName) | |||
| glog.Warning(s) | |||
| s := fmt.Sprintf("References a non-existent ClusterServicePlan %q on ClusterServiceClass %q", instance.Spec.ExternalClusterServicePlanName, serviceClass.Spec.ExternalName) | |||
There was a problem hiding this comment.
Can we disambiguate the k8s and external names in this PR where it isn't already done?
There was a problem hiding this comment.
sure! I can add that.
k8s-ci-robot
added
size/XL
|
@pmorie take another look, thanks! |
added 2 commits
October 13, 2017 07:53
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After working with controller bindings, I learned some things about how we want to log info. Updating last PR to be more like the new way.
Part of #1279