This repository has been archived by the owner on May 6, 2022. It is now read-only.
Return dashboard url in responses to update service-instance requests #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
pmorie
reviewed
Apr 3, 2018
| @@ -4524,7 +4524,9 @@ func TestResolveReferencesNoClusterServicePlan(t *testing.T) { | |||
| func TestReconcileServiceInstanceUpdatePlan(t *testing.T) { | |||
| fakeKubeClient, fakeCatalogClient, fakeClusterServiceBrokerClient, testController, sharedInformers := newTestController(t, fakeosb.FakeClientConfiguration{ | |||
| UpdateInstanceReaction: &fakeosb.UpdateInstanceReaction{ | |||
| Response: &osb.UpdateInstanceResponse{}, | |||
| Response: &osb.UpdateInstanceResponse{ | |||
There was a problem hiding this comment.
We've added feature gates for other validating-through-implementation features - will you add one for this feature? Check out pkg/features.
| @@ -536,6 +536,7 @@ func (c *controller) reconcileServiceInstanceUpdate(instance *v1beta1.ServiceIns | |||
| return c.processServiceInstanceOperationError(instance, readyCond) | |||
| } | |||
|
|
|||
| instance.Status.DashboardURL = response.DashboardURL | |||
There was a problem hiding this comment.
feature gate can be tested here.
jberkhahn
force-pushed
the
return_dashboard_url
branch
from
a51df74 to
519d068
Compare
k8s-ci-robot
added
size/L
|
Updated this, moved the tests around. @pmorie tell me what you think |
pmorie
reviewed
Apr 4, 2018
| @@ -536,6 +536,11 @@ func (c *controller) reconcileServiceInstanceUpdate(instance *v1beta1.ServiceIns | |||
| return c.processServiceInstanceOperationError(instance, readyCond) | |||
| } | |||
|
|
|||
| if utilfeature.DefaultFeatureGate.Enabled(scfeatures.UpdateDashboardURL) { | |||
| // if response.DashboardURL != nil { | |||
There was a problem hiding this comment.
Did you mean to leave these commented out?
jberkhahn
force-pushed
the
return_dashboard_url
branch
from
519d068 to
2296487
Compare
|
@pmorie cleaned this up, wrote some more tests. I'm not 100% sure I did the integration tests right, would appreciate another look. Thanks! |
arschles
approved these changes
Apr 12, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a validation through implementation of OSB #437.
Also bumps pmorie/go-open-service-broker-client.