Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Do not include UUID in get class|plan output #1977

Merged
merged 2 commits into from
Apr 26, 2018

Conversation

carolynvs
Copy link
Contributor

@carolynvs carolynvs commented Apr 24, 2018

The --uuid flag is still there, but to save space and make room for displaying broker and namespace, hide this ugly (mostly ignored) column.

$ svcat get classes
               NAME                         DESCRIPTION
+--------------------------------+--------------------------------+
  azure-postgresql-database        Azure Database for
                                   PostgreSQL-- database only
                                   (preview)
  azure-sql-database               Azure SQL-- database only
                                   (preview)

$ svcat get plans
              NAME                           CLASS                         DESCRIPTION
+------------------------------+--------------------------------+--------------------------------+
  database                       azure-postgresql-database        A new database added to an
                                                                  existing DBMS
  premium-p2                     azure-sql-database               PremiumP2 Tier, 250 DTUs,
                                                                  500GB, 35 days point-in-time
                                                                  restore

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2018
@MHBauer
Copy link
Contributor

MHBauer commented Apr 24, 2018

at what point do we add a COLUMNS specifier rather than a flag for individual things I want to see?

I think in kube there's -o template and json and json path support.

@carolynvs
Copy link
Contributor Author

at what point do we add a COLUMNS specifier rather than a flag for individual things I want to see?

Just thinking about going down that path makes me want to go back to what I had originally suggested, just not showing uuid in the get output (while continuing to support the uuid filter).

I don't want to get in the business of supporting kubectl's entire design/framework... 😝

One sec, just the thought of that has made me 💩 my pants. Update incoming...

@carolynvs carolynvs force-pushed the no-uuid-in-get-table branch from bf424bf to bc7f860 Compare April 24, 2018 21:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2018
@carolynvs carolynvs force-pushed the no-uuid-in-get-table branch from bc7f860 to 155b546 Compare April 24, 2018 21:47
The --uuid flag is still there, but to save space and make room for
displaying broker + namespace, hide this ugly (mostly ignored) column.
@carolynvs carolynvs force-pushed the no-uuid-in-get-table branch from 5081d8b to 948f624 Compare April 24, 2018 21:48
@carolynvs carolynvs changed the title Conditionally display UUID in describe output with --uuid flag Do not include UUID in get class|plan output Apr 24, 2018
@jboyd01
Copy link
Contributor

jboyd01 commented Apr 25, 2018

I kind of feel like we should have a flag that causes the output to include the UUID, but tbh, I hate the UUID and would like to never see it again. So I guess the fallback if you really must have UUID is to use native kubectl get clusterserviceclasses/clusterserviceplans. And generally if dealing with UUID you already know the UUID and you want details on the object. So... LGTM.

@jboyd01 jboyd01 added the LGTM1 label Apr 25, 2018
@carolynvs
Copy link
Contributor Author

carolynvs commented Apr 25, 2018

To be clear, you can always use --uuid with both get and describe and describe's output includes the uuid. But yeah it's awful, and I don't want to encourage us to jump through hoops or take on a crap ton of work that's already in kubectl to support something that hopefully won't live on much longer (see pauls stuff on human readable names).

Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHBauer MHBauer added the LGTM2 label Apr 26, 2018
@MHBauer MHBauer merged commit 7796611 into kubernetes-retired:master Apr 26, 2018
@carolynvs carolynvs deleted the no-uuid-in-get-table branch October 4, 2018 21:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. LGTM1 LGTM2 size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants