This repository has been archived by the owner on May 6, 2022. It is now read-only.
Make svcat broker commands with --wait support namespaced brokers #2615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
jberkhahn
changed the title
k8s-ci-robot
added
the
size/L
MHBauer
approved these changes
Apr 29, 2019
| if timeout == nil { | ||
| notimeout := time.Duration(math.MaxInt64) | ||
| timeout = ¬imeout | ||
| } | ||
| err = wait.PollImmediate(interval, *timeout, | ||
| func() (bool, error) { | ||
| broker, err = sdk.retrieveBroker(name) |
There was a problem hiding this comment.
this is really the key shift, from some internal name function to the name/id with scoping options added. both already existed and I guess continue to exist until some later refactor.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jboyd01 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/test pull-service-catalog-xbuild |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a
What this PR does / why we need it:
svcat broker commands with the --wait flag now wait for namespaced brokers
Which issue(s) this PR fixes
fixes #2593
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update