Change creates statements in walkthrough.md

[mszostok]

Description

• Change creates statements in walkthrough.md. Thanks to that command can be directly copied and executed in terminal without cloning the service-catalog source code
• fix namespace name in cleaning up service catalog step
• fix typo

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mszostok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[MHBauer]

is okay-ish.

[MHBauer]

"... assume internet connectivity. Download the yaml ahead of time to etc etc etc."

Some people have to proxy in or out to github.

[mszostok]

but basically, k8s is doing that on their examples:

kubectl apply -f https://k8s.io/examples/controllers/nginx-deployment.yaml

but just using that with k8s.io domain.
source: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#creating-a-deployment

In the future, we can also host examples under https://svc-cat.io site.

thanks to that you can copy-paste command directly to terminal without service catalog sources, so it's huge pros. What's more, you will know that the newest version was used.
In case of doing that with checkout repo, someone can have an old version (didnt execute git pull for a long time)

but as you said such an approach requires the connection connectivity

So what is your idea? Leave it as it is and required that use checkout the service catalog locally as it was before?

[MHBauer]

Ah, yes, the walkthrough is hosted.
https://svc-cat.io/docs/walkthrough/

Would be good to have it hosted on the domain, but not a blocker.

[mszostok]

ok, I will implement that in next pull-requests

[MHBauer]

good catch, dupe word.

[MHBauer]

This should link back to other instructions rather than document how to clean up something else here.

[mszostok]

agree 👍

[mszostok]

FYI: The best approach was to remove that thing. At the beginning of that walkthrough we have a prerequisite:
This document assumes that you've installed Service Catalog onto your cluster.

so I do not see any reason why we should have the delete action for SC at the end of the walkthrough. We can delete the minibroker because we are creating that during the walkthrough.

so the final shape:

# Step 1 - Installing the minibroker Server
# Step 2 - Viewing ClusterServiceClasses and ClusterServicePlans
# Step 4 - Creating a New ServiceInstance
# Step 5 - Requesting a ServiceBinding to use the ServiceInstance
# Step 6 - Deleting the ServiceBinding
# Step 7 - Deleting the ServiceInstance
# Step 8 - Deleting the ClusterServiceBroker
# Step 9 - Final Cleanup - delete minibroker and created namespaces

thanks to that the walkthrough is exactly about showing usage of SC

[MHBauer]

seems fine. forward progress.
/lgtm

[mszostok]

/hold

[piotrmiskiewicz]

/lgtm

[mszostok]

/hold cancel