Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Remove unused api server implementation from master branch #2720

Merged
merged 1 commit into from
May 15, 2020
Merged

Remove unused api server implementation from master branch #2720

merged 1 commit into from
May 15, 2020

Conversation

mszostok
Copy link
Contributor

@mszostok mszostok commented Oct 4, 2019

Description

  • This PRs removes all unnecessary code related to api-server which is not used anymore.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 4, 2019
@mszostok mszostok force-pushed the remove-api-server-impl branch from 3df5a98 to 6d43cfb Compare October 4, 2019 09:03
MHBauer
MHBauer approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@MHBauer MHBauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good riddance to badly designed rubbish.

@mszostok mszostok mentioned this pull request Oct 28, 2019
Closed
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 3, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 2, 2020
@jberkhahn
Copy link
Contributor

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Feb 3, 2020
@mszostok mszostok force-pushed the remove-api-server-impl branch from 6d43cfb to abd3415 Compare May 8, 2020 17:48
@mszostok mszostok marked this pull request as ready for review May 8, 2020 17:48
@k8s-ci-robot k8s-ci-robot removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 8, 2020
@mszostok mszostok added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels May 8, 2020
@mszostok
Copy link
Contributor Author

mszostok commented May 8, 2020

/test pull-service-catalog-test-integration

@mszostok
Copy link
Contributor Author

mszostok commented May 8, 2020

travis is failing because of that issue: #2794

@mszostok mszostok removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2020
@MHBauer
Copy link
Contributor

MHBauer commented May 8, 2020

weird, travis page is green

@mszostok
Copy link
Contributor Author

mszostok commented May 8, 2020 •
edited
Loading

yes because I restarted that job manually after #2794 was merged to master
Screen Shot 2020-05-09 at 00 05 27
In logs there is now info that it uses jekyll/jekyll:4.0

but tbh I didnt know that travis is not keeping logs from previous executions, quite strange

This was referenced May 10, 2020
Merged
Closed
Closed
@mszostok mszostok force-pushed the remove-api-server-impl branch 3 times, most recently from a35541f to 4e003de Compare May 14, 2020 17:03
@mszostok mszostok force-pushed the remove-api-server-impl branch from 4e003de to 7bedcdb Compare May 14, 2020 17:22
@piotrmiskiewicz
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit fd45c0d into kubernetes-retired:master May 15, 2020
@MHBauer
Copy link
Contributor

MHBauer commented May 15, 2020

Nice 👌

@mszostok mszostok deleted the remove-api-server-impl branch May 19, 2020 20:30
This was referenced May 19, 2020
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MHBauer MHBauer MHBauer approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

Assignees

@piotrmiskiewicz piotrmiskiewicz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mszostok @k8s-ci-robot @fejta-bot @jberkhahn @MHBauer @piotrmiskiewicz