-
Notifications
You must be signed in to change notification settings - Fork 382
cleanup codebase and run gofmt #2729
cleanup codebase and run gofmt #2729
Conversation
Signed-off-by: Guangming Wang <[email protected]>
Welcome @beautytiger! |
Hi @beautytiger. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @beautytiger, thanks for the PR :) but what kind of checks did you execute to perform such changes? var service map[string]interface{}
service = services[0].(map[string]interface{}) to var service = services[0].(map[string]interface{}) if it's automated then maybe we will consider to add it to our pipeline |
@mszostok |
Thanks @beautytiger if you are interested then I can assist you with that:) /lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: beautytiger, mszostok The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is a
What this PR does / why we need it:
Cleanup codebase
Which issue(s) this PR fixes
Fixes #
Please leave this checklist in the PR comment so that maintainers can ensure a good PR.
Merge Checklist:
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update