Improve data migration process (restore crds)

[adamwalach]

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:
It fixes minor problems in the migration process:

• fixed retry function
• improved error wrapping

Which issue(s) this PR fixes
Fixes kyma-project/kyma#5993

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Hi @adamwalach. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mszostok]

/ok-to-test

[mszostok]

test pull-service-catalog-test-migration failed, you need to add proper rbac:

I1015 14:23:33.692100       1 migration.go:669] Removing owner referneces from secrets
Error: when removing owner references from secrets: servicebindings.servicecatalog.k8s.io is forbidden: User "system:serviceaccount:catalog:migration-job-account" cannot list resource "servicebindings" in API group "servicecatalog.k8s.io" at the cluster scope
==== END logs for container job of pod catalog/catalog-catalog-migration-job-22b65 ====

source: https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_service-catalog/2730/pull-service-catalog-test-migration/1184109479549997057/artifacts/logs/catalog/catalog-catalog-migration-job-22b65/logs.txt

[adamwalach]

/test pull-build-all-images-for-s390x

[adamwalach]

/test pull-build-all-images-for-ppc64le

[mszostok]

/lgtm

[mszostok]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamwalach, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mszostok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment