Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Changing Class and Plans labels to sha224 #2741

Merged
merged 2 commits into from
Nov 5, 2019
Merged

Changing Class and Plans labels to sha224 #2741

merged 2 commits into from
Nov 5, 2019

Conversation

jasiu001
Copy link
Contributor

@jasiu001 jasiu001 commented Nov 4, 2019

This PR is a

  • Feature Implementation
  • Bug Fix
  • Documentation

Which issue(s) this PR fixes

  • this PR fixes issue #2739 and #2736
  • version 0.2 (with apiserver) allowed (Cluster)ServiceBroker names longer than 63 chars, the new version does not allow due to Kubernetes label restriction. This PR fixes this issue.
  • version 0.2 (with apiserver) allowed (Cluster)ServicePlan names with '_' char at the beginning, the new version does not allow due to Kubernetes label restriction. This PR fixes this issue.
  • this PR changes all labels values to sha224, thanks to this, the name length does not exceed 57 chars

additionally, this PR fixes:

  • displays the class to which the plan belongs during kubectl command
  • adds labels to ServiceInstance containing the class it belongs to

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

  • New feature
    • Tests
    • Documentation
  • SVCat CLI flag
  • Server Flag for config
    • Chart changes
    • removing a flag by marking deprecated and hiding to avoid
      breaking the chart release and existing clients who provide a
      flag that will get an error when they try to update

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 4, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @jasiu001. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 4, 2019
@piotrmiskiewicz
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 4, 2019
@jasiu001 jasiu001 mentioned this pull request Nov 4, 2019
Closed
@jasiu001
Copy link
Contributor Author

jasiu001 commented Nov 4, 2019

/test pull-service-catalog-test-integration

@mszostok mszostok self-requested a review November 4, 2019 13:26
@jasiu001 jasiu001 mentioned this pull request Nov 4, 2019
Closed
piotrmiskiewicz
piotrmiskiewicz approved these changes Nov 4, 2019
View reviewed changes
pkg/util/sha_generator.go
)

// GenerateSHA generates the sha224 value from the given string
func GenerateSHA(input string) string {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, add a comment that the result must not be longer than 63 characters and the algorithm must not be changed in the future.

@piotrmiskiewicz
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2019
@mszostok
Copy link
Contributor

mszostok commented Nov 5, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jasiu001, mszostok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit f5f69f5 into kubernetes-retired:master Nov 5, 2019
This was referenced Nov 5, 2019
Closed
Closed
Merged
@jasiu001 jasiu001 mentioned this pull request Nov 7, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@piotrmiskiewicz piotrmiskiewicz piotrmiskiewicz approved these changes

@jberkhahn jberkhahn Awaiting requested review from jberkhahn

@mszostok mszostok Awaiting requested review from mszostok

Assignees

@piotrmiskiewicz piotrmiskiewicz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasiu001 @k8s-ci-robot @piotrmiskiewicz @mszostok