Change Deployment api to apps/v1 in cleaner

[vivekzhere]

• Deployment.extensions/v1beta1 depricated from k82 1.16
• Remove activeDeadlineSeconds from migration jobs
• The generic timeout from will be applied

Fixes: #2752

This PR is a

• Feature Implementation
• Bug Fix
• Documentation

What this PR does / why we need it:

Which issue(s) this PR fixes

Fixes #2752

Please leave this checklist in the PR comment so that maintainers can ensure a good PR.

Merge Checklist:

• New feature
  • Tests
  • Documentation
• SVCat CLI flag
• Server Flag for config
  • Chart changes
  • removing a flag by marking deprecated and hiding to avoid
    breaking the chart release and existing clients who provide a
    flag that will get an error when they try to update

[k8s-ci-robot]

Hi @vivekzhere. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mszostok]

/ok-to-test

[mszostok]

Could you also change it in:
https://github.com/kubernetes-sigs/service-catalog/blob/0b5180b6c37de62bec5fe621da8f9aca47cea1bf/test/upgrade/examiner/internal/readiness/readiness.go#L86

it's just one line:) as a result we will get rid of the AppsV1beta1 from our code:)

[mszostok]

You need to remove the closes: statement from you commit body as it is not allowed:)

kubernetes/test-infra#9360

[mszostok]

could you also remove the activeDeadlineSeconds for each migration jobs?

Currently it's only 100sec and I can see that it's sometimes timeouted on our pipeline. The problem is that we cannot have the timeout there because it depends on the number of resources and it may differ between cluster, so we cannot set any reasonable default. The best option is to allow the generic timeout from helm to be applied
e.g. helm upgrade catalog svc-cat/catalog --timeout 3600

thanks in advance!

[vivekzhere]

Removed AppsV1beta1 from readiness test.
Removed activeDeadlineSeconds from migration jobs
Removed closes from commit message

[mszostok]

/lgtm

[jberkhahn]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, vivekzhere

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jberkhahn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vivekzhere]

/test pull-service-catalog-test-migration