Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Adding helm3 command #2764

Merged
merged 4 commits into from
Mar 10, 2020
Merged

Adding helm3 command #2764

merged 4 commits into from
Mar 10, 2020

Conversation

prary
Copy link
Contributor

@prary prary commented Dec 12, 2019

Helm3 search in helm reposub-command unlike Helm2.

This PR is a

  • Feature Implementation
  • Bug Fix
  • [ * ] Documentation

What this PR does / why we need it:
This PR updates the documentation with helm3 sub-command.

@prary
Adding helm3 command
c79222e 
Helm3 search in `helm repo`sub-command unlike Helm2.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @prary. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 12, 2019
@prary
Copy link
Contributor Author

prary commented Dec 12, 2019

/assign @MHBauer

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 18, 2019
@jberkhahn
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2020
@jberkhahn
Copy link
Contributor

/retest

1 similar comment
@jberkhahn
Copy link
Contributor

/retest

@jberkhahn
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn, prary

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit c9f7c96 into kubernetes-retired:master Mar 10, 2020
@mszostok mszostok mentioned this pull request May 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MHBauer MHBauer Awaiting requested review from MHBauer

@mszostok mszostok Awaiting requested review from mszostok

Assignees

@jberkhahn jberkhahn

@MHBauer MHBauer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prary @k8s-ci-robot @jberkhahn @MHBauer