polkitAuthenticationDialog: Use the new StPasswordEntry

linuxmint · Nov 4, 2024 · d368157 · d368157
1 parent 9ea9d8f
commit d368157
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/js/ui/polkitAuthenticationAgent.js b/js/ui/polkitAuthenticationAgent.js
@@ -105,14 +105,14 @@ var AuthenticationDialog = GObject.registerClass({
             vertical: true,
         });
 
-        this._passwordEntry = new St.Entry({
+        this._passwordEntry = new St.PasswordEntry({
             style_class: 'prompt-dialog-password-entry',
             text: "",
             can_focus: true,
             visible: false,
             x_align: Clutter.ActorAlign.CENTER,
         });
-        CinnamonEntry.addContextMenu(this._passwordEntry, { isPassword: true });
+        CinnamonEntry.addContextMenu(this._passwordEntry);
         this._passwordEntry.clutter_text.connect('activate', this._onEntryActivate.bind(this));
         this._passwordEntry.bind_property('reactive',
             this._passwordEntry.clutter_text, 'editable',
@@ -121,6 +121,12 @@ var AuthenticationDialog = GObject.registerClass({
 
         let warningBox = new St.BoxLayout({ vertical: true });
 
+        let capsLockWarning = new CinnamonEntry.CapsLockWarning();
+        this._passwordEntry.bind_property('visible',
+            capsLockWarning, 'visible',
+            GObject.BindingFlags.SYNC_CREATE);
+        warningBox.add_child(capsLockWarning);
+
         this._errorMessageLabel = new St.Label({
             style_class: 'prompt-dialog-error-label',
             visible: false,
@@ -292,10 +298,7 @@ var AuthenticationDialog = GObject.registerClass({
         else
             this._passwordEntry.hint_text = request;
 
-        if (echoOn)
-            this._passwordEntry.clutter_text.set_password_char('');
-        else
-            this._passwordEntry.clutter_text.set_password_char('\u25cf'); // ● U+25CF BLACK CIRCLE
+        this._passwordEntry.password_visible = echoOn;
 
         this._passwordEntry.show();
         this._passwordEntry.set_text('');