Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix MSBuild 14 path to sn.exe #202

Merged
merged 1 commit into from
Aug 18, 2015

Conversation

yaakov-h
Copy link
Contributor

Fix for #179 (and maybe #160?).

@sharwell
Copy link
Member

I believe this works on some systems but not others.

I need to do a bit more investigating.

@yaakov-h
Copy link
Contributor Author

Alright.

@SergeyTeplyakov
Copy link
Contributor

Currently Roslyn is using the same targets: https://github.com/dotnet/roslyn/blob/9362f37f29898abd5bd4f0e6be127ab7a947a806/build/Targets/VSL.Settings.targets#L233

And I thought that the second line should be valid only in the rare cases. But I agree with @sharwell this fix would be partial as well: it will work in one configurations but not work in the others.

@yaakov-h
Copy link
Contributor Author

What configurations would have MSBuild 14.0 without Windows SDK 10.0A? Visual Studio 2015 provides both, as best I can tell, and on my Windows 8.1 machine with VS2008, VS2013 and VS2015, only Windows SDK 10.0A has .NET 4.6 Tools.

I'll have to investigate further why $(TargetFrameworkSDKToolsDirectory) isn't being used in my case, but if I build a dummy project with msbuild and /v:diag, the following line appears in the output:

TargetFrameworkSDKToolsDirectory = C:\Program Files (x86)\Microsoft SDKs\Windows\v10.0A\bin\NETFX 4.6 Tools\

@sharwell
Copy link
Member

I checked this on a Windows 10 machine and a Windows 7 machine, and found that with Visual Studio 2015 RTM a copy of sn.exe was located as specified in this pull request. I haven't verified the location on AppVeyor, but based on the results so far I'm ready to 👍 this pull request.

@yaakov-h
Copy link
Contributor Author

Just following up here - @SergeyTeplyakov, can you specify any configurations where this would not work, or is this OK?

@SergeyTeplyakov
Copy link
Contributor

@yaakov-h I'll check on my working machine later today.

@yaakov-h
Copy link
Contributor Author

As opposed to your broken machine? :)

@SergeyTeplyakov
Copy link
Contributor

Yep. I've checked my Windows 8.1 machine and sn is located in the place specified by the PR.

Merging....

SergeyTeplyakov added a commit that referenced this pull request Aug 18, 2015
@SergeyTeplyakov SergeyTeplyakov merged commit 0eceb0f into microsoft:master Aug 18, 2015
@yaakov-h yaakov-h deleted the fix-msbuild-14 branch April 24, 2018 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants