-
Notifications
You must be signed in to change notification settings - Fork 151
Conversation
I believe this works on some systems but not others. I need to do a bit more investigating. |
Alright. |
Currently Roslyn is using the same targets: https://github.com/dotnet/roslyn/blob/9362f37f29898abd5bd4f0e6be127ab7a947a806/build/Targets/VSL.Settings.targets#L233 And I thought that the second line should be valid only in the rare cases. But I agree with @sharwell this fix would be partial as well: it will work in one configurations but not work in the others. |
What configurations would have MSBuild 14.0 without Windows SDK 10.0A? Visual Studio 2015 provides both, as best I can tell, and on my Windows 8.1 machine with VS2008, VS2013 and VS2015, only Windows SDK 10.0A has .NET 4.6 Tools. I'll have to investigate further why
|
I checked this on a Windows 10 machine and a Windows 7 machine, and found that with Visual Studio 2015 RTM a copy of sn.exe was located as specified in this pull request. I haven't verified the location on AppVeyor, but based on the results so far I'm ready to 👍 this pull request. |
Just following up here - @SergeyTeplyakov, can you specify any configurations where this would not work, or is this OK? |
@yaakov-h I'll check on my working machine later today. |
As opposed to your broken machine? :) |
Yep. I've checked my Windows 8.1 machine and sn is located in the place specified by the PR. Merging.... |
Fix MSBuild 14 path to sn.exe
Fix for #179 (and maybe #160?).