This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
For 64-bit assemblies, preserve the imagebase value when rewriting. #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wise causes bad assemblies if the module's imageBase is bigger than 0x400000.
|
Looks good to me. |
|
Thanks for taking care of this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Up until now, the .imagebase value written into assemblies was 0x400000. This works for 32-bit assemblies, but not for 64-bit assemblies. So I tried to preserve the value read in on an assembly and use that when writing it. This seems to work for 64-bit assemblies, but for some reason can create a bad 32-bit assembly if the input assembly had a value greater than the default. I tried to debug this, but the header values written by CCI1 and CCI2 are different and it isn't clear to me how they are computed. So I left the old behavior for 32-bit assemblies and have the new behavior only for 64-bit assemblies.