This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Add flag to generate cccheck RSP at build time #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tually running cccheck.exe
| { | ||
| this.handleError(new Error(1080, message, binding.SourceContext)); | ||
| } | ||
| this.handleError(new Error(1080, message, binding.SourceContext)); |
There was a problem hiding this comment.
Not clear from this review: does it really guaranteed that handleError is not null?
There was a problem hiding this comment.
There's an invariant on it as non-null. It's also only set from the constructor, which has a precondition for non-null.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to the MSBuild properties,
CodeContractsDeferCodeAnalysis. If this is set, Code Contracts will do everything it need to do for static analysis except actually runcccheck.exe.This allows developers and automated build processes to manually run the static check at a later time by invoking
cccheck.exe @MyAssemblyName.rsp.This option is exposed in the Visual Studio properties pane as 'Create checking artifacts only'. If this option is selected, 'Check in background' and 'Fail build on warnings' are disabled as they are no longer relevant.
This PR also includes minor fixes observed from the BuildCC.bat build log, and renames the RSP files from
MyAssemblyNameccrewrite.rsp, for example, toMyAssemblyName.ccrewrite.rsp.This has been functionally tested in Visual Studio 2015.