Skip to content

Commit

Permalink
chore: fix firefox tests after switching to context delegate (#34898)
Browse files Browse the repository at this point in the history
  • Loading branch information
yury-s authored Feb 23, 2025
1 parent e091baa commit 954457b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions packages/playwright-core/src/server/firefox/ffPage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@ export class FFPage implements PageDelegate {
const context = await parent._mainContext();
const result = await this._session.send('Page.adoptNode', {
frameId: frame._id,
executionContextId: ((context as any)[contextDelegateSymbol] as FFExecutionContext)._executionContextId
executionContextId: (context.delegate as FFExecutionContext)._executionContextId
});
if (!result.remoteObject)
throw new Error('Frame has been detached.');
Expand All @@ -570,5 +570,3 @@ export class FFPage implements PageDelegate {
function webSocketId(frameId: string, wsid: string): string {
return `${frameId}---${wsid}`;
}

const contextDelegateSymbol = Symbol('delegate');

0 comments on commit 954457b

Please sign in to comment.