Allow closing tabs with middle mouse button when close button is hidden #15924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
reviewed
Sep 4, 2023
| { | ||
| if (_pointerMiddleButtonPressed && !eventArgs.GetCurrentPoint(*this).Properties().IsMiddleButtonPressed()) | ||
| { | ||
| _pointerMiddleButtonPressed = false; |
There was a problem hiding this comment.
_pointerMiddleButtonExited must be reset to false as well, doesn't it?
There was a problem hiding this comment.
_pointerMiddleButtonExited is reset on each _OnTabPointerPressed and updated on each enter/exit event. Not strictly needed to clear it here.
|
Updated with review changes. |
|
I'm sorry we left this one on read for so long! We're quieting down for the holidays, but I will make sure that we get a look at it as soon as is possible after that. Thank you for fixing this bug. |
lhecker
approved these changes
Jan 10, 2024
|
Any news about this? Thanks. |
microsoft-github-policy-service
bot
requested review from
zadjii-msft,
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
|
Rebased to resolve merge conflict. |
This commit fixes the middle mouse button handler. The `PointerReleased` callback is registered, but it is not operational because, on the Release event, the mouse button is no longer pressed. We need to track its state and act accordingly. Issue was introduced by commit 05e7ea1, which changed the event handler from `PointerPressed` to `PointerReleased`, rendering it inoperative. Instead, the default handler is used. The main issue is that when the close button is hidden with the `showCloseButton` option, the default handler no longer closes the tab on middle mouse clicks. Also made it consistent with the Settings tab, which was never converted to `PointerReleased` and is still handled with a custom handler.
lhecker
approved these changes
Sep 9, 2024
microsoft-github-policy-service
bot
removed
the
Needs-Second
carlos-zamora
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This commit fixes the middle mouse button handler. The
PointerReleasedcallback is registered, but it is not operational because, on the Release event, the mouse button is no longer pressed. We need to track its state and act accordingly.Issue was introduced by commit 05e7ea1, which changed the event handler from
PointerPressedtoPointerReleased, rendering it inoperative. Instead, the default handler is used. The main issue is that when the close button is hidden with theshowCloseButtonoption, the default handler no longer closes the tab on middle mouse clicks.Also made it consistent with the Settings tab, which was never converted to
PointerReleasedand is still handled with a custom handler.References and Relevant Issues
Related commit 05e7ea1
Validation Steps Performed
I've been using this commit locally for quite some time, figured out I might as well share it.