Add new and extend existing til::string helpers #16772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-CodeHealth
DHowett
approved these changes
Feb 27, 2024
DHowett
approved these changes
Feb 27, 2024
lhecker
commented
Feb 27, 2024
Comment on lines
+158
to
+162
| const auto comparator = [&](const Editor::Font& lhs, const Editor::Font& rhs) { | ||
| const auto a = lhs.LocalizedName(); | ||
| const auto b = rhs.LocalizedName(); | ||
| return til::compare_linguistic_insensitive(a, b) < 0; | ||
| }; |
There was a problem hiding this comment.
Oh, I forgot to mention that this also fixes a minor bug. The < operator on strings is not safe for proper Unicode comparisons. It's based on wmemcmp which tests for binary equivalence, so it neither works for case-sensitive nor case-insensitive comparisons in the context of Unicode. For instance, because a composed and decomposed grapheme doesn't compare equal.
zadjii-msft
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wstring_case_insensitive_compareis not a great name for what itdoes as it's incorrect to use for regular (human readable) strings.
This PR thus renames it to
env_key_sorter.compare_string_ordinalwas renamed tocompare_ordinal_insensitiveto make sure callers know that the comparison is insensitive
(this may otherwise be incorrect in certain contexts after all).
The return value was changed to match
memcmpso that the APIis detached from its underlying implementation (= NLS).
compare_linguistic_insensitiveandcontains_linguistic_insensitivewere added to sort and filter human-readable strings respectively.
prefix_splitwas extended to allow for needles that are just asingle character. This significantly improves the generated assembly
and is also usually what someone would want to actually use.
I've left the string-as-needle variant in just in case.
This PR is prep-work for #2664