-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon override setting for newTabMenu entries #18116
Add icon override setting for newTabMenu entries #18116
Conversation
@microsoft-github-policy-service agree |
Adds documentation about the new icon override feature for profile and action entries (PR: microsoft/terminal#18116)
oh, I think I need to comment here before it will run pipelines now. FLY, MY PRETTIES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much - this is excellent work! Exactly what we needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you!
Adds documentation about the new icon override feature for profile and action entries to be introduced by PR: microsoft/terminal#18116 Also added a section on "action" entries as it was previously missing.
Summary of the Pull Request
This PR is to allow users to set a custom icon for entries in the new tab menu for "action" and "profile" type entries.
References and Relevant Issues
This PR is in response to #18103
Detailed Description of the Pull Request / Additional comments
It is now possible to specify an optional "icon" setting for any "action" or "profile" type entry in the "newTabMenu" JSON settings. When specified, this icon will be used as the menu icon for that action/profile in the new tab menu. If not specified, the action/profile definition's default icon will be used instead (if present).
The Cascadia settings schema ("doc/cascadia/profiles.schema.json") has been updated to reflect this.
Validation Steps Performed
Manually tested with multiple combinations of icon settings:
PR Checklist