Support arm64 native CppUnitTestFramework with dotnet test
#3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoRossignoli
requested review from
nohwnd and
Evangelink
and removed request for
nohwnd
Evangelink
approved these changes
Jun 16, 2022
nohwnd
approved these changes
Jun 16, 2022
src/Microsoft.TestPlatform.TestHostProvider/Hosting/DotnetTestHostManager.cs
Outdated
Show resolved
Hide resolved
|
@MarcoRossignoli not sure how to revoke my approval without blocking you from merging. So I just disabled automerge. Should the native detection run when we know that the default architecture is set? |
we should never force if native, native test container is expected to be the same architecture of "current" process. |
This was referenced Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support
dotnet test nativeArm64.dll