WinRT activation shim for Microsoft.Management.Deployment #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florelis
approved these changes
Aug 7, 2024
| <Configuration>ReleaseStatic</Configuration> | ||
| <Platform>x64</Platform> | ||
| </ProjectConfiguration> | ||
| <ProjectConfiguration Include="Release|ARM64"> |
There was a problem hiding this comment.
We don't currently ship it in the nuget package this is headed for.
Comment on lines
+198
to
+199
| <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|ARM64'">true</TreatWarningAsError> | ||
| <TreatWarningAsError Condition="'$(Configuration)|$(Platform)'=='Debug|x64'">true</TreatWarningAsError> |
There was a problem hiding this comment.
Not needed, but I'd love if you could remove all the conditions to keep a single one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Modeled after the similar project for
Microsoft.Management.Configuration, this new project enables WinRT standard activation viaDllGetActivationFactoryandIActivationFactory. The major change required was to add support for multiple classes.Validation
Manually updated the sample caller to use WinRT style activation for the
PackageManagerclass and verified that placing the (renamed) .dll next to its .exe resulted in a proper functionality.Microsoft Reviewers: Open in CodeFlow