Add missing top-level exception handling for arg validation #5111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Jan 7, 2025
| } | ||
| catch (...) | ||
| { | ||
| return Workflow::HandleException(context, std::current_exception()); |
There was a problem hiding this comment.
nit: Workflow::HandleException handles GroupPolicyException above. Btw I don't have preference on whether we would list GroupPolicyException above explicitly or let HandleException handle all non-command exceptions.
There was a problem hiding this comment.
I'm in favor of having explicit handling in this case, since the message for Group Policy is quite clear about what is happening
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLI arg validation code has gotten more complicated and now there is more room for exceptions to occur. For example, if there is an error when reading the admin settings or group policies that determine if an argument is available.
This adds generic exception handling at the top-level of arg validation so that we can exit gracefully and show an error, instead of just crashing.
Partial fix for #5098. This addresses the no output, but not the cause of the error
Microsoft Reviewers: Open in CodeFlow