Merge pull request #2422 from uklotzde/qobject_cast

Use qobject_cast for accessing the sender() of received signals
mixxxdj · Jan 2, 2020 · 8b88cb1 · 8b88cb1
2 parents 8546643 + 18d1609
commit 8b88cb1
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/library/sidebarmodel.cpp b/src/library/sidebarmodel.cpp
@@ -385,7 +385,7 @@ QModelIndex SidebarModel::translateSourceIndex(const QModelIndex& index) {
      * For child models, this always the child models itself
      */
 
-    const QAbstractItemModel* model = dynamic_cast<QAbstractItemModel*>(sender());
+    const QAbstractItemModel* model = qobject_cast<QAbstractItemModel*>(sender());
     VERIFY_OR_DEBUG_ASSERT(model != NULL) {
         return QModelIndex();
     }

diff --git a/src/musicbrainz/network.cpp b/src/musicbrainz/network.cpp
@@ -59,7 +59,7 @@ void NetworkTimeouts::addReply(QNetworkReply* reply) {
 }
 
 void NetworkTimeouts::replyFinished() {
-    QNetworkReply* reply = reinterpret_cast<QNetworkReply*>(sender());
+    QNetworkReply* reply = qobject_cast<QNetworkReply*>(sender());
     if (m_timers.contains(reply)) {
         killTimer(m_timers.take(reply));
     }

diff --git a/src/musicbrainz/tagfetcher.cpp b/src/musicbrainz/tagfetcher.cpp
@@ -66,7 +66,7 @@ void TagFetcher::cancel() {
 }
 
 void TagFetcher::fingerprintFound(int index) {
-    QFutureWatcher<QString>* watcher = reinterpret_cast<QFutureWatcher<QString>*>(sender());
+    QFutureWatcher<QString>* watcher = static_cast<QFutureWatcher<QString>*>(sender());
     if (!watcher || index >= m_tracks.count()) {
         return;
     }