Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add --values-first flag to swap values and labels in the input #95

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

maxim-kukushkin
Copy link

Termgraph is a useful CLI tool and it can become even more useful if it can seamlessly integrate with existing bin utils. One example of the latter one is sort and uniq commands in Unix-like systems.

Adding | sort | uniq -c to your pipeline is often useful to get some statistics. The problem is that it prints the number of occurrences first, and then the actual label string. This is goes in contrast to what Termgraph expects and thus visualizing these numbers would require an extra pre-processing like an awk script.

This PR adds --values-first flag to Termgraph, making it assume that each line first contains the values and labels go as the last column (vs. the default behavior where labels are the first column).

ex10.dat shows that it works with multiple value columns as well. Respective unit test was added.

With this change, it's possible to do the following: | sort | uniq -c | termgraph --values-first and have it visualize the data.

The input data would look like this:

     16 alter
     17 create
     15 drop
     12 insert
      8 update

@maxim-kukushkin
Copy link
Author

Any chance to get reviews on this PR? Or may be suggestions if community/code owner find that this feature must not be there

@maxim-kukushkin
Copy link
Author

any thoughts?

@maxim-kukushkin
Copy link
Author

@mkaz, any chance you can have a look at this change?

@maxim-kukushkin
Copy link
Author

@mkaz, are you still maintaining the repo or is it abandoned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant