Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dirs from 2.0.2 to 4.0.0 #1071

Merged
merged 1 commit into from
Sep 27, 2021
Merged

Bump dirs from 2.0.2 to 4.0.0 #1071

merged 1 commit into from
Sep 27, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 27, 2021

Bumps dirs from 2.0.2 to 4.0.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [dirs](https://github.com/soc/dirs-rs) from 2.0.2 to 4.0.0.
- [Release notes](https://github.com/soc/dirs-rs/releases)
- [Commits](https://github.com/soc/dirs-rs/commits)

---
updated-dependencies:
- dependency-name: dirs
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Sep 27, 2021
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay

@jcape
Copy link
Contributor

jcape commented Sep 27, 2021

4

    BREAKING CHANGE The behavior of executable_dir has been adjusted to not depend on $XDG_DATA_HOME. Code, which assumed that setting the $XDG_DATA_HOME environment variable also impacted executable_dir if the $XDG_BIN_HOME environment variable was not set, requires adjustment.
    Add support for XDG_STATE_HOME.

3

    BREAKING CHANGE The behavior of config_dir on macOS has been adjusted (thanks to everyone involved):
        The existing config_dir function has been changed to return the Application Support directory on macOS, as suggested by Apple documentation.
        The behavior of the config_dir function on non-macOS platforms has not been changed.
        If you have used the config_dir function to store files, it may be necessary to write code that migrates the files to the new location on macOS.
        (Alternative: change uses of the config_dir function to uses of the preference_dir function to retain the old behavior.)
    The newly added preference_dir function returns the Preferences directory on macOS now, which – according to Apple documentation – shall only be used to store .plist files using Apple-proprietary APIs. – preference_dir and config_dir behave identical on non-macOS platforms.

@jcape jcape self-assigned this Sep 27, 2021
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like we're only using dirs::home_dirs(), which is not listed as containing breaking changes.

@jcape jcape merged commit 980eb9f into master Sep 27, 2021
@jcape jcape deleted the dependabot/cargo/dirs-4.0.0 branch September 27, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants