Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump clap from 3.2.22 to 4.0.10 #2665

Merged
merged 5 commits into from
Oct 10, 2022
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 6, 2022

Bumps clap from 3.2.22 to 4.0.10.

Release notes

Sourced from clap's releases.

v4.0.10

[4.0.10] - 2022-10-05

Features

  • (derive) Support #[arg(flatten)] on Option types (#4211, #4350)

v4.0.9

[4.0.9] - 2022-10-03

Fixes

  • (derive) Process doc comments for #[command(subcommand)] like in clap v3

v4.0.8

[4.0.8] - 2022-10-01

Fixes

  • (derive) Remove a low-value assert preventing defaulting Help and Version actions

v4.0.7

[4.0.7] - 2022-09-30

Features

  • (derive) Populate implicit ArgGroup (#3165)

Fixes

  • (derive) Support #[group(skip)] on Parser derive
  • (derive) Tell users about implicit arg groups when running into group name conflicts
  • (error) Don't report unrelated groups in conflict or requires errors

v4.0.6

[4.0.6] - 2022-09-30

Features

v4.0.5

[4.0.5] - 2022-09-30

v4.0.4

[4.0.4] - 2022-09-29

Fixes

  • (error) Specialize the self-conflict error to look like clap v3

... (truncated)

Changelog

Sourced from clap's changelog.

[4.0.10] - 2022-10-05

Features

  • (derive) Support #[arg(flatten)] on Option types (#4211, #4350)

[4.0.9] - 2022-10-03

Fixes

  • (derive) Process doc comments for #[command(subcommand)] like in clap v3

[4.0.8] - 2022-10-01

Fixes

  • (derive) Remove a low-value assert preventing defaulting Help and Version actions

[4.0.7] - 2022-09-30

Features

  • (derive) Populate implicit ArgGroup (#3165)

Fixes

  • (derive) Support #[group(skip)] on Parser derive
  • (derive) Tell users about implicit arg groups when running into group name conflicts
  • (error) Don't report unrelated groups in conflict or requires errors

[4.0.6] - 2022-09-30

Features

[4.0.5] - 2022-09-30

[4.0.4] - 2022-09-29

Fixes

  • (error) Specialize the self-conflict error to look like clap v3

[4.0.3] - 2022-09-29

Fixes

  • (error) Quote literals consistently
  • (error) Stylize escape (--) suggestions

... (truncated)

Commits
  • af1234a chore: Release
  • f921281 docs: Update changelog
  • f86cd0f Merge pull request #4350 from epage/option
  • 78676f5 fix(derive): Make mismatched behavior more obvious
  • 06d2049 feat(derive): Support 'Option' when flattening
  • 33db640 refactor(derive): Make flatten's update prepped for Option
  • f121a8b fix(derive): Better subcommand type errors for Vec
  • 4f17f99 fix(derive): Better flatten type errors
  • 232d91b docs: Describe the skip attribute for ValueEnums (#4328)
  • 9c21794 Merge pull request #4348 from mattmadeofpasta/clarify_no_long_help_text_for_p...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [clap](https://github.com/clap-rs/clap) from 3.2.22 to 4.0.10.
- [Release notes](https://github.com/clap-rs/clap/releases)
- [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md)
- [Commits](clap-rs/clap@v3.2.22...v4.0.10)

---
updated-dependencies:
- dependency-name: clap
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added old-v4.0.0 Blocker for v4 dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Oct 6, 2022
Clap 4.0 automatically derives a group named by the Parser struct.  This
group name needs to be unique, which means any other Parser structs used
will collide if they use the same name.
Copy link
Contributor

@cbeck88 cbeck88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you

Copy link
Contributor

@eranrund eranrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for picking this up.
Mostly nits and small questions, but I do think we should avoid implementing Clone on a private key just to satisfy a command line parsing crate.

Previously there was a blanket `clone()` implementation for
Ed25519Private.  This has been replaced with a more localized newtype
wrapper, where the clone was needed, around Ed25519Private
@nick-mobilecoin nick-mobilecoin force-pushed the dependabot/cargo/clap-4.0.10 branch from df44709 to 59da7e7 Compare October 7, 2022 20:14
The initial update to clap 4.0 instances of os_str parsing or similar
were replaced with `value_parser`.  A bar `value_parser` is not needed
as it's the default.

Also removed the `hex` feature from `mc-util-parse` and left it as an
always available functionality
@nick-mobilecoin nick-mobilecoin merged commit c69132f into master Oct 10, 2022
@nick-mobilecoin nick-mobilecoin deleted the dependabot/cargo/clap-4.0.10 branch October 10, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file old-v4.0.0 Blocker for v4 rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants