-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump clap from 3.2.22 to 4.0.10 #2665
Conversation
Bumps [clap](https://github.com/clap-rs/clap) from 3.2.22 to 4.0.10. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@v3.2.22...v4.0.10) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Clap 4.0 automatically derives a group named by the Parser struct. This group name needs to be unique, which means any other Parser structs used will collide if they use the same name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for picking this up.
Mostly nits and small questions, but I do think we should avoid implementing Clone
on a private key just to satisfy a command line parsing crate.
Previously there was a blanket `clone()` implementation for Ed25519Private. This has been replaced with a more localized newtype wrapper, where the clone was needed, around Ed25519Private
df44709
to
59da7e7
Compare
The initial update to clap 4.0 instances of os_str parsing or similar were replaced with `value_parser`. A bar `value_parser` is not needed as it's the default. Also removed the `hex` feature from `mc-util-parse` and left it as an always available functionality
Bumps clap from 3.2.22 to 4.0.10.
Release notes
Sourced from clap's releases.
... (truncated)
Changelog
Sourced from clap's changelog.
... (truncated)
Commits
af1234a
chore: Releasef921281
docs: Update changelogf86cd0f
Merge pull request #4350 from epage/option78676f5
fix(derive): Make mismatched behavior more obvious06d2049
feat(derive): Support 'Option' when flattening33db640
refactor(derive): Make flatten's update prepped for Optionf121a8b
fix(derive): Better subcommand type errors for Vec4f17f99
fix(derive): Better flatten type errors232d91b
docs: Describe the skip attribute for ValueEnums (#4328)9c21794
Merge pull request #4348 from mattmadeofpasta/clarify_no_long_help_text_for_p...Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)