adjust readiness criteria for fog view #3149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What caused this shift: "main bottleneck was loading the data from Postgres, but now it's actually putting the data into ORAM."? |
|
@samdealy i think before, the latency between fog view and postgres was very high, and fog view would only request one block at a time. we made a patch that made it request many more (configurable) blocks at a time and that increased the throughput with the postgres connection considerably. since then i think oram is the bottleneck and not postgres |
|
planning to retarget to v4.1 |
Jason reported that fog view is now declaring itself ready well before the highest-processed-block-count is close to the block height. In the past, the main bottleneck was loading the data from Postgres, but now it's actually putting the data into ORAM. In this commit, we refine the readiness criteria, so that both the db fetcher and the enclave loading thread have to run out of work before the server declares itself ready.
Co-authored-by: Emily C. <[email protected]>
cbeck88
force-pushed
the
refine-fog-view-readiness-criteria
branch
from
aa4c8f4 to
58b693c
Compare
samdealy
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jason reported that fog view is now declaring itself ready well before the highest-processed-block-count is close to the block height.
In the past, the main bottleneck was loading the data from Postgres, but now it's actually putting the data into ORAM.
In this commit, we refine the readiness criteria, so that both the db fetcher and the enclave loading thread have to run out of work before the server declares itself ready.