-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracked_sessions field to consensus service #3155
Conversation
❌ Heads up, I tried building full-service using this branch and it failed. |
✅ Good job, full-service was built successfully. |
There are still clippy lints that need to be fixed. |
3ad31dd
to
2b60692
Compare
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
❌ Heads up, I tried building full-service using this branch and it failed. |
39fe366
to
001ba38
Compare
❌ Heads up, I tried building full-service using this branch and it failed. |
001ba38
to
4e23c5f
Compare
Adds a
tracked_sessions
field to consensus service and a_tracked_sessions
field to the client API service in consensus, as well as aClientSessionTracking
struct, to fill with tracked session information, which is a stub at present.Motivation
Some way of keeping track of how many failed tx proposals have been sent recently needs to be available, so that bad connections can be dropped, to prevent attacks and harmful behavior from buggy clients. See: #2977
Future Work
The rest of #2977, as in: