Update lint script to lint root workspace once #3501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-mobilecoin
force-pushed
the
nick/lint-root-once
branch
from
0dc10c2 to
6e0f0d4
Compare
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Aug 13, 2023
nick-mobilecoin
force-pushed
the
nick/warnings-ci-only
branch
from
91d124d to
b50335e
Compare
nick-mobilecoin
force-pushed
the
nick/lint-root-once
branch
from
6e0f0d4 to
7e0df3b
Compare
Previously clippy would run twice on the root workspace. Now the root workspace is only linted once.
nick-mobilecoin
force-pushed
the
nick/lint-root-once
branch
from
7e0df3b to
f3c2b57
Compare
eranrund
reviewed
Sep 18, 2023
cargo fmt is now run before cargo clippy in `tools/lint.sh` this ensures the quicker check to fail will fail first.
eranrund
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously clippy would run twice on the root workspace.
Now the root workspace is only linted once.