Add UnverifiedReport state for attestation #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new state `UnverifiedReport` as been added to the attest key exchange state machine. The `UnverifiedReport` allows clients like watcher to get the attestation report from the key exchange handshake without requiring the report to pass verification. This is useful when the client doesn't know or need to know the identity of the enclave.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Aug 21, 2023
eranrund
reviewed
Aug 22, 2023
Previously the `UnverifiedReport` returned a `Ready` state which would allow subsequent communication. Now the `UnverifiedReport` returns a `Terminated` state. This is meant to prevent a client from accidentally talking to an unknown enclave, thinking it's trusted, by using an `UnverifiedReport` handshake.
This was referenced Aug 22, 2023
nick-mobilecoin
commented
Aug 22, 2023
eranrund
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new state
UnverifiedReportas been added to the attest key exchangestate machine. The
UnverifiedReportallows clients like watcher toget the attestation report from the key exchange handshake without
requiring the report to pass verification. This is useful when the
client doesn't know or need to know the identity of the enclave.