Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart upgrades #3545

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Helm chart upgrades #3545

merged 2 commits into from
Sep 12, 2023
+9 −3

Conversation

aweis89
Copy link
Contributor

@aweis89 aweis89 commented Sep 11, 2023 •
edited
Loading

  • Fixes shardOverlap templating to use correct value
  • Adds name override to reduce name & label length of shards and routers
  • Adds a Delete retention policy to the ledger router and ledger shards PVC cleanup

Motivation

Future Work

Soundtrack of this PR

@aweis89 aweis89 force-pushed the feature/helm-v5-updates branch from 14b7ec0 to 1419d79 Compare September 11, 2023 21:34
@aweis89 aweis89 changed the title fix shardOverlap; add fullnameOverride Helm chart upgrades Sep 12, 2023
jgreat
jgreat approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aweis89 aweis89 merged commit 2e6b92b into release/v5.0 Sep 12, 2023
@aweis89 aweis89 deleted the feature/helm-v5-updates branch September 12, 2023 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgreat jgreat jgreat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aweis89 @jgreat