Add Digestible impl to EnclaveReportDataContents
#3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `EnclaveReportDataContents` is a member of `DcapEvidence` which will need to be part of `BlockMetadataContents` which derives `Digestible`. In order to support this future need a `Digestible` implementation has been added to the `EnclaveReportDataContents`. Also add `EnclaveReportDataContents` to the external protobufs. To accomodate the need of it being part of the `BlockMetadataContents` in the protobufs.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
nick-mobilecoin
commented
Sep 13, 2023
nick-mobilecoin
commented
Sep 13, 2023
nick-mobilecoin
commented
Sep 13, 2023
This was referenced Sep 13, 2023
eranrund
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
EnclaveReportDataContentsis a member ofDcapEvidencewhich willneed to be part of
BlockMetadataContentswhich derivesDigestible.In order to support this future need a
Digestibleimplementation hasbeen added to the
EnclaveReportDataContents.Also add
EnclaveReportDataContentsto the external protobufs. Toaccomodate the need of it being part of the
BlockMetadataContentsinthe protobufs.