New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fog `Report` to use `AttestationEvidence` #3589

Merged

nick-mobilecoin merged 3 commits into master from nick/fog-report-evidence

Sep 29, 2023

Collaborator

nick-mobilecoin commented Sep 28, 2023 •

edited

Loading

Previously the Report structure in fog used VerificationReport. Now
this usage has been updated to AttestationEvidence to accommodate DCAP
evidence.

Collaborator Author

nick-mobilecoin commented Sep 28, 2023 •

edited

Loading

Current dependencies on/for this PR:

master
- PR From instead of TryFrom for proto to prost #3592
  - PR Update fog Report to use AttestationEvidence #3589 👈

This comment was auto-generated by Graphite.

nick-mobilecoin commented

View reviewed changes

fog/ingest/report/src/lib.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/recovery_db_iface/src/types.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/report/api/tests/fog_types.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/report/types/src/lib.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/report/types/src/lib.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/sql_recovery_db/src/lib.rs Show resolved Hide resolved

nick-mobilecoin commented

View reviewed changes

fog/sql_recovery_db/src/lib.rs Outdated Show resolved Hide resolved

nick-mobilecoin requested review from eranrund and dolanbernard

September 28, 2023 20:31

nick-mobilecoin marked this pull request as draft

September 28, 2023 20:59

nick-mobilecoin removed request for eranrund and dolanbernard

September 28, 2023 20:59

Collaborator Author

nick-mobilecoin commented Sep 28, 2023

moving to draft to track down fog test errors

nick-mobilecoin force-pushed the nick/fog-report-evidence branch from adbf25f to ab1af52 Compare

September 28, 2023 23:08

nick-mobilecoin commented

View reviewed changes

fog/report/types/src/lib.rs Show resolved Hide resolved

nick-mobilecoin force-pushed the nick/fog-report-evidence branch from ab1af52 to ef4379e Compare

September 28, 2023 23:21

nick-mobilecoin marked this pull request as ready for review

September 28, 2023 23:47

nick-mobilecoin requested review from eranrund and dolanbernard

September 28, 2023 23:47

eranrund approved these changes

View reviewed changes

fog/report/api/src/lib.rs Outdated Show resolved Hide resolved

fog/report/api/tests/fog_types.rs Show resolved Hide resolved

nick-mobilecoin changed the base branch from master to nick/prost-tryfrom-proto-to-from

September 29, 2023 15:47

nick-mobilecoin force-pushed the nick/fog-report-evidence branch from ef4379e to 8ff394b Compare

September 29, 2023 15:47

nick-mobilecoin mentioned this pull request

From instead of TryFrom for proto to prost #3592

Merged

Collaborator Author

nick-mobilecoin commented Sep 29, 2023 •

edited

Loading

Merge Activity

Sep 29, 4:35 PM: @nick-mobilecoin started a stack merge that includes this pull request via Graphite.
Sep 29, 4:35 PM: Graphite rebased this pull request as part of a merge.
Sep 29, 5:09 PM: Graphite couldn't merge this PR because it was not satisfying all requirements.

Base automatically changed from nick/prost-tryfrom-proto-to-from to master

September 29, 2023 20:35

nick-mobilecoin force-pushed the nick/fog-report-evidence branch from 8ff394b to 519b346 Compare

September 29, 2023 20:35

nick-mobilecoin added 3 commits

September 29, 2023 14:23


          Update fog Report to use AttestationEvidence

5c43a95

Previously the `Report` structure in fog used `VerificationReport`. Now
this usage has been updated to `AttestationEvidence` to accommodate DCAP
evidence.


          Use into() instead of try_into()

9d7c7b3


          Update lock files for 5.0.8 merge

c66d25d

nick-mobilecoin force-pushed the nick/fog-report-evidence branch from 519b346 to c66d25d Compare

September 29, 2023 21:26

nick-mobilecoin enabled auto-merge (squash)

September 29, 2023 21:26

nick-mobilecoin merged commit 23b8665 into master

nick-mobilecoin deleted the nick/fog-report-evidence branch

September 29, 2023 22:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet