Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables dcap #3749

Merged
merged 34 commits into from
Jan 5, 2024
Merged

Enables dcap #3749

merged 34 commits into from
Jan 5, 2024

Conversation

aweis89
Copy link
Contributor

@aweis89 aweis89 commented Nov 28, 2023

Motivation

Future Work

Soundtrack of this PR

aweis89 added 21 commits November 16, 2023 21:40
@aweis89
adds dcap docker build
382b6fe
@aweis89
update bootstrap-tools
2f976ef
@aweis89
remove sgx resources
52ee709
@aweis89
adds annotations
2311c91
@aweis89
remove aesm-service
f753d06
@aweis89
update wrapper script
db43de5
@aweis89
add new package
53f5d25
@aweis89
adds securityContext
e88dae3
@aweis89
updates fog-ingest manifests
0ee04b0
@aweis89
upgrades fog-ledger
286d1fc
@aweis89
adds fog ledger store
fe8b76e
@aweis89
remove ias references
4732a0a
@aweis89
update fog-view
d8bdb17
@aweis89
add consensus-node podAnnotations
effd91f
@aweis89
adds privileged permissions
c9e9f58
@aweis89
removes privileged
3598092
@aweis89
Merge remote-tracking branch 'origin/main' into feature/dcap-cd-witho…
92ba315 
…ut-priv
@aweis89
Merge branch 'main' into feature/dcap-cd-without-priv
76426ba
@aweis89
remove comment
5f04f6d
@aweis89
Merge branch 'feature/dcap-cd-without-priv' of https://github.com/mob…
a0a1c52 
…ilecoinfoundation/mobilecoin into feature/dcap-cd-without-priv
@aweis89
Merge branch 'main' into feature/dcap-cd-without-priv
c3483cb
joekottke
joekottke previously requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@joekottke joekottke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ledger-distribution check in the node_hw entrypoint definitely needs to be added back in, and I'm curious about the resource definitions/amounts.

@aweis89 aweis89 requested a review from joekottke December 12, 2023 20:18
jgreat
jgreat requested changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor clean up on formatting.

Side note I would love if we could find a automatic yaml linting tool with something like .rc rules so we can standardize.

@aweis89 aweis89 force-pushed the feature/dcap-cd-without-priv branch from 870a0ce to d6b53a1 Compare January 2, 2024 22:30
@aweis89
Copy link
Contributor Author

aweis89 commented Jan 2, 2024 •
edited
Loading

Some minor clean up on formatting.

Side note I would love if we could find a automatic yaml linting tool with something like .rc rules so we can standardize.

Ironically I've been using yamlls which does formatting as well, but it actually seems to prefer to double quotes so I needed to turn it off to revert the "true" to 'true', but that seems be configurable if we want to change the default

@aweis89 aweis89 requested a review from jgreat January 3, 2024 01:50
jgreat
jgreat approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@jgreat jgreat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will follow up with sgx.intel.com/epc values.

@aweis89 aweis89 enabled auto-merge (squash) January 3, 2024 23:57
@jgreat jgreat dismissed joekottke’s stale review January 5, 2024 20:36

The ledger-distibution startup is back in.

@aweis89 aweis89 merged commit 4f46b13 into main Jan 5, 2024
80 checks passed
@aweis89 aweis89 deleted the feature/dcap-cd-without-priv branch January 5, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgreat jgreat jgreat approved these changes

@joekottke joekottke Awaiting requested review from joekottke

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aweis89 @joekottke @jgreat