Fix ledger stores not updating latest block info #3771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a a7b70f6 the ledger stores were optimized to fetch only the blocks they needed. This caused an error during collation where the minimum of the known blocks are past back to clients. This resulted in only being able to provide the blocks from the lowest shard to the clients. Now shards will continue to poll for the latest block allowing for all shards to be accounted for when collating the response.
eranrund
approved these changes
Dec 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a7b70f6 the ledger stores were optimized to fetch only the blocks they needed. This caused an error during collation where the minimum of the known blocks are past back to clients. This resulted in only being able to provide the blocks from the lowest shard to the clients. Now shards will continue to poll for the latest block allowing for all shards to be accounted for when collating the response.