Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fog ledger router returning incorrect block number #3933

Merged
merged 3 commits into from
Apr 12, 2024
Merged

Fix fog ledger router returning incorrect block number #3933

merged 3 commits into from
Apr 12, 2024

Conversation

nick-mobilecoin
Copy link
Collaborator

Previously when a fog ledger store was spun up prior to the block chain
having blocks in its block range it would return back 0 for the block
number. This resulted in the collated response having 0 for the total
number of blocks. Now stores will respond back with the range of
blocks that they have processed and the collation logic will combine the
overlapping ranges to come up with the highest available block count.

This was referenced Feb 27, 2024
Merged
Closed
sugargoat
sugargoat approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@sugargoat sugargoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Left several comments mostly for my own edification

Base automatically changed from nick/range-logic to release/v6.0 April 12, 2024 14:18
@nick-mobilecoin
Fix fog ledger router returning incorrect block number
cdc7799 
Previously when a fog ledger store was spun up prior to the block chain
having blocks in its block range it would return back 0 for the block
number. This resulted in the collated response having 0 for the total
number of blocks. Now stores will respond back with the range of
blocks that they have processed and the collation logic will combine the
overlapping ranges to come up with the highest available block count.
@nick-mobilecoin
Address review comments
d62fe5f
@nick-mobilecoin
Prevent infinite loop by always checking for stop requested first
1c282bf
@nick-mobilecoin nick-mobilecoin force-pushed the nick/response_with_ranges branch from 993f0ca to 1c282bf Compare April 12, 2024 14:20
@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/android-bindings failed to build. Check actions status for details.

@github-actions GitHub Actions
Copy link

⚠️ Downstream repo mobilecoinofficial/full-service failed to build. Check actions status for details.

@nick-mobilecoin nick-mobilecoin merged commit c8cf339 into release/v6.0 Apr 12, 2024
96 checks passed
@nick-mobilecoin nick-mobilecoin deleted the nick/response_with_ranges branch April 12, 2024 20:40
@nick-mobilecoin nick-mobilecoin mentioned this pull request Apr 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugargoat sugargoat sugargoat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-mobilecoin @sugargoat