Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use if-let chains #295

Merged
merged 7 commits into from Jul 16, 2019
Merged

Use if-let chains #295

merged 7 commits into from Jul 16, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jul 15, 2019

Per Issue #195, I have gone through and added some if-let chains instead of pattern matching. Would appreciate any feedback you may have. Thanks!

@codecov-io
Copy link

codecov-io commented Jul 15, 2019

Codecov Report

Merging #295 into master will decrease coverage by 10.2%.
The diff coverage is 73.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #295       +/-   ##
===========================================
- Coverage   80.17%   69.96%   -10.21%     
===========================================
  Files          11       11               
  Lines        3541     3533        -8     
  Branches      871      870        -1     
===========================================
- Hits         2839     2472      -367     
- Misses        355      357        +2     
- Partials      347      704      +357
Impacted Files Coverage Δ
src/parser.rs 62% <ø> (-17.45%) ⬇️
src/path_rewriting.rs 70.1% <0%> (-15.04%) ⬇️
src/lib.rs 63.4% <100%> (-9.66%) ⬇️
src/gcov.rs 70.21% <33.33%> (-10.64%) ⬇️
src/producer.rs 86% <76.19%> (-5.46%) ⬇️
src/output.rs 69.72% <77.77%> (-6.54%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c005222...dca1e9a. Read the comment docs.

@marco-c
Copy link
Collaborator

marco-c commented Jul 15, 2019

Thanks, it looks good overall!

marco-c
marco-c previously approved these changes Jul 15, 2019
Copy link
Collaborator

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost
Copy link
Author

ghost commented Jul 15, 2019

Any thoughts on why the codecov was so shot by these changes? I didn't really look into the tests, should I dig into that a bit?

@marco-c marco-c merged commit 0ac13c2 into mozilla:master Jul 16, 2019
@marco-c
Copy link
Collaborator

marco-c commented Jul 16, 2019

Any thoughts on why the codecov was so shot by these changes? I didn't really look into the tests, should I dig into that a bit?

No, no worries, I think it's just imprecise. We have to fix it somehow.

@ghost
Copy link
Author

ghost commented Jul 16, 2019

Any thoughts on why the codecov was so shot by these changes? I didn't really look into the tests, should I dig into that a bit?

No, no worries, I think it's just imprecise. We have to fix it somehow.

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants