-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use if-let chains #295
Use if-let chains #295
Conversation
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
===========================================
- Coverage 80.17% 69.96% -10.21%
===========================================
Files 11 11
Lines 3541 3533 -8
Branches 871 870 -1
===========================================
- Hits 2839 2472 -367
- Misses 355 357 +2
- Partials 347 704 +357
Continue to review full report at Codecov.
|
Thanks, it looks good overall! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Any thoughts on why the codecov was so shot by these changes? I didn't really look into the tests, should I dig into that a bit? |
No, no worries, I think it's just imprecise. We have to fix it somehow. |
Great, thanks! |
Per Issue #195, I have gone through and added some if-let chains instead of pattern matching. Would appreciate any feedback you may have. Thanks!